home-manager icon indicating copy to clipboard operation
home-manager copied to clipboard

micro: add bindings, ensurePlugins, and trueColor options

Open pbsds opened this issue 3 years ago • 2 comments

Description

Add ability to configure keybinds and a micro-specific environ variable. I also added the ability to install micro plugins during activation.

In the future i/someone might end up packaging the plugins properly, hence the odd, deprecateable, option name ensurePlugins.

Checklist

  • [x] Change is backwards compatible.

  • [x] Code formatted with ./format.

  • [ ] Code tested through nix-shell --pure tests -A run.all.

  • [x] Code tested through nix-shell --pure tests -A run.micro.

  • [x] Test cases updated/added. See example.

  • [x] Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • [x] Added myself as module maintainer. See example.

    • [x] Added myself and the module files to .github/CODEOWNERS.

pbsds avatar Sep 14 '22 18:09 pbsds

Thanks! I've added a few comments. The activation time plugin installation is my main concern. I think it would be best to go directly for the proper plugin packaging.

CC @MForster

rycee avatar Sep 19 '22 21:09 rycee

Oh, and you can improve the commit message by avoiding to put everything the summary. Something like

micro: add a few new options

This adds the options

- `bindings`,
- `ensurePlugins`, and
- `enableTrueColor`.

rycee avatar Sep 19 '22 21:09 rycee

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

  • GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
  • If it is unfinished but you plan to finish it, please mark it as a draft.
  • If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
  • To get things rolling again, rebase the PR against the target branch and address valid comments.
If you are not the original author of the PR

  • If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

stale[bot] avatar Dec 18 '22 22:12 stale[bot]

Draft until nixos/nixpkgs#192680 is merged. I'm plan on giving it some love during the holydays

pbsds avatar Dec 21 '22 14:12 pbsds

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

  • GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
  • If it is unfinished but you plan to finish it, please mark it as a draft.
  • If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
  • To get things rolling again, rebase the PR against the target branch and address valid comments.
If you are not the original author of the PR

  • If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

stale[bot] avatar Mar 22 '23 01:03 stale[bot]

Any update here? @rycee

phip1611 avatar Mar 22 '24 08:03 phip1611

@phip1611 Not much I can do. I think this is waiting for the plugins to be available in Nixpkgs?

rycee avatar Mar 22 '24 11:03 rycee

I have a new version of https://github.com/NixOS/nixpkgs/pull/192680 i've yet to push, but i have to test it properly and currently i'm crunching on a paper. In april i will finally have more time. :)

pbsds avatar Mar 22 '24 15:03 pbsds