buildbot-nix icon indicating copy to clipboard operation
buildbot-nix copied to clipboard

Parse evaluation warnings and display in separate section.

Open MagicRB opened this issue 1 year ago • 8 comments

A live version can be seen here and in case my buildbot dies or gets reset, a screenshot:

image

Possibly fixes #172, for anything more fancy we'll need #173, what do you think @zimbatm?

And due to the exploration here, I've learned that we can add arbitrary HTML to the page, as long as it is contained in one of those tabs. Well, injecting javascript and modifying the page is an option, but a really bad one :)

MagicRB avatar Jun 12 '24 16:06 MagicRB

Anything more than this is blocked by #173 and further discussion is needed, as buildbot does not allow partial UI replacements as far as I can tell, therefore we cannot add another element into the build UI.

MagicRB avatar Jun 12 '24 17:06 MagicRB

Unless the eval error gets more visibility, it makes sense to table this for now.

zimbatm avatar Jun 13 '24 08:06 zimbatm

@mergify rebase

Mic92 avatar Jun 13 '24 09:06 Mic92

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Jun 13 '24 09:06 mergify[bot]

This is superseded by #255 as now evaluation failures appear as separate builds. image

MagicRB avatar Sep 11 '24 17:09 MagicRB

But is this the same as warnings though?

Mic92 avatar Sep 21 '24 16:09 Mic92

But is this the same as warnings though? Those

Mic92 avatar Sep 21 '24 16:09 Mic92

Ah yeah if the build doesn't fail it doesn't show. That's my mistake.

MagicRB avatar Sep 21 '24 16:09 MagicRB

Fixed: https://github.com/nix-community/buildbot-nix/pull/485

Mic92 avatar Sep 11 '25 15:09 Mic92