nitroshare-desktop icon indicating copy to clipboard operation
nitroshare-desktop copied to clipboard

Wrong installation pathes for breeze and breeze-dark icons

Open rapgro opened this issue 9 years ago • 8 comments

The path "breeze-dark/apps/22/nitroshare-indicator.svg" looks wrong to me. Better use "breeze-dark/scalable/apps/nitroshare-indicator.svg" Analogously for breeze instead of breeze-dark.

rapgro avatar Jul 12 '16 12:07 rapgro

Fix with this script:

mkdir -p src/dist/icons/breeze-dark/scalable src/dist/icons/breeze/scalable mv src/dist/icons/breeze-dark/apps/22 src/dist/icons/breeze-dark/scalable/apps mv src/dist/icons/breeze/apps/22 src/dist/icons/breeze/scalable/apps rm -rfv src/dist/icons/breeze*/apps

rapgro avatar Jul 12 '16 13:07 rapgro

No, this icons are labeled correctly. The "breeze" icons are shown on a light background and must use a dark color to stand out from the background. Conversely, the "breeze-dark" icons are shown on a dark background and must show a light color to stand out.

nathan-osman avatar Jul 12 '16 22:07 nathan-osman

I think you missed the point. It's not about removing the icons, it's about a wrong directory they get installed to. Your directory structure is against XDG standard. https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#directory_layout

rapgro avatar Jul 13 '16 07:07 rapgro

Oh, I'm sorry. I misunderstood what you were saying. I'll take a look at this tomorrow.

nathan-osman avatar Jul 13 '16 07:07 nathan-osman

not addressed in 0.3.3

rapgro avatar Jul 15 '16 07:07 rapgro

Is that still actual? @rapgro maybe send a patch?

abitrolly avatar Apr 26 '18 06:04 abitrolly

not addressed in 0.3.4 https://src.fedoraproject.org/rpms/nitroshare/blob/master/f/nitroshare.spec#_107 @abitrolly Look above for the patch.

rapgro avatar Jul 22 '18 05:07 rapgro

@rapgro send it here - https://github.com/nitroshare/nitroshare-desktop/pulls

abitrolly avatar Jul 22 '18 06:07 abitrolly