jmacaroons icon indicating copy to clipboard operation
jmacaroons copied to clipboard

Use a more familiar verifier API

Open cyberdelia opened this issue 3 years ago • 2 comments
trafficstars

A change in a similar fashion as the builders one, but for verifiers.

MacaroonsVerifier verifier = macaroon.verifier();
verifier.satisfy("account = 3735928559");

A more subtle change is also hiding here, by using List rather Array where there is no advantages in using Array (which is in holding primitive types).

cyberdelia avatar Feb 07 '22 22:02 cyberdelia

Codecov Report

Merging #37 (9765a47) into master (aaa50a4) will decrease coverage by 0.24%. The diff coverage is 70.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #37      +/-   ##
============================================
- Coverage     65.16%   64.92%   -0.25%     
+ Complexity      241      237       -4     
============================================
  Files            25       25              
  Lines          1289     1280       -9     
  Branches        179      177       -2     
============================================
- Hits            840      831       -9     
- Misses          352      355       +3     
+ Partials         97       94       -3     
Impacted Files Coverage Δ
...m/github/nitram509/jmacaroons/util/ArrayTools.java 88.23% <ø> (+4.36%) :arrow_up:
...9/jmacaroons/verifier/TimestampCaveatVerifier.java 88.88% <ø> (ø)
...github/nitram509/jmacaroons/MacaroonsVerifier.java 78.57% <66.66%> (-2.28%) :arrow_down:
...java/com/github/nitram509/jmacaroons/Macaroon.java 70.17% <100.00%> (+0.53%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aaa50a4...9765a47. Read the comment docs.

codecov-commenter avatar Feb 07 '22 22:02 codecov-commenter

Thank you very much for your contibution. I will have a look at this PR soon.

nitram509 avatar Feb 14 '22 18:02 nitram509