Nitish Malhotra

Results 73 comments of Nitish Malhotra
trafficstars

See https://github.com/kubernetes-sigs/kind/issues/2063#issuecomment-775734522

For clarity `make dev` would deploy Orkestra helm chart with `values-ci.yaml` i.e. start with orkestra controller disabled. This will allow the end-user to run their local changes either using the...

> 3rd Wednesday of the month. 10am PT. > > https://docs.google.com/document/d/1DKR4VQ-04DJfHOh6S6-cbQw6MiWppC0k7afORiiy6XQ/edit > > November. Will do !

For reference, the two places where this happens currently are, Orkestra: https://github.com/Azure/orkestra/blob/main/pkg/workflow/argo.go#L121-L133 Workflow Executor: https://github.com/Azure/orkestra-workflow-executor/blob/main/main.go#L116-L136

Additionally we should also add event generation to the workflow executor

I think giving generated HelmReleases a unique id based on the workflow UUID might be right thing to do.

This is a great idea - I think I have a duplicate issue for this #112 Let me prioritize this! /cc @jonathan-innis @helayoty

@helayoty assigning this to you as this is higher in priority and might be something that gives you a chance to understand the architecture and codebase