react-perf-devtool icon indicating copy to clipboard operation
react-perf-devtool copied to clipboard

Question: Firefox v52 supported?

Open jrnail23 opened this issue 7 years ago • 6 comments
trafficstars

Is react-perf-devtool supposed to work with Firefox v52? Since I couldn't get the browser extensions working, I'm using the custom callback to write metrics to my console. While it works fine in Chrome, nothing happens in Firefox v52 (I'm trying to investigate performance issues specific to FFv52). It looks like my callback just isn't getting invoked.

jrnail23 avatar Aug 30 '18 15:08 jrnail23

I think I uploaded the Firefox build too last time but it's not being actively maintained since I am the only one who is taking care of code, docs, support and other maintaining stuff 😅

nitin42 avatar Aug 30 '18 15:08 nitin42

@nitin42, I totally understand, and thanks for being so responsive! To be clear, my specific issue here isn't with the browser extensions, but with react-perf-devtool's observer callback -- the callback should work without the extension, right?

jrnail23 avatar Aug 30 '18 15:08 jrnail23

It should work!

Look at the screenshot below, you should be able to see the console logging the object _REACT_PERF_DEVTOOL_GLOBAL_STORE

screenshot 2018-08-30 at 11 34 41 pm

I am using Firefox quantum (latest release)

Make sure you are using the current stable [email protected]

nitin42 avatar Aug 30 '18 18:08 nitin42

in Firefox v52, __REACT_PERF_DEVTOOL_GLOBAL_STORE__ is undefined (but in Chrome, of course, it's fine). I'm guessing maybe this older version of Firefox just isn't compatible with the performance API being used -- again, I'm intentionally on an older version to troubleshoot specific customer problems, so this isn't terribly surprising.

Anyway, you can probably just go ahead and close this issue. Keep up the good work -- I'm looking forward to seeing what this tool can do!

jrnail23 avatar Aug 30 '18 18:08 jrnail23

Thanks! Yes, it seems like that version of Firefox doesn't support PerformanceObserver. Let me check if we can use a polyfill here, so I'll keep this issue open!

nitin42 avatar Aug 30 '18 19:08 nitin42

Set to on hold, if anyone finds a polyfill for window.PerformanceObserver (or when polyfill.io adds it) we can polyfill it to add support for older browser versions! For now, I'll add a notice in the README for Browser Compatibility.

flxwu avatar Sep 11 '18 09:09 flxwu