glamorous-primitives icon indicating copy to clipboard operation
glamorous-primitives copied to clipboard

Deprecation: createClass & failed proptypes

Open alechp opened this issue 8 years ago • 2 comments

Output on clean install / render:

screen shot 2017-10-03 at 3 11 16 pm

> [email protected] start .../react-sketchapp-glamorous
> npm run render


> [email protected] render .../react-sketchapp-glamorous
> skpm build --watch --run

🖨  Copied src/manifest.json in 4ms
Warning: Accessing createClass via the main React package is deprecated, and will be removed in React v16.0. Use a plain JavaScript class instead. If you're not yet ready to migrate, create-react-class v15.* is available on npm as a temporary, drop-in replacement. For more info see https://fb.me/react-create-class
Warning: Failed prop type: Invalid prop `style` of type `array` supplied to `View`, expected `object`.
    in View (created by glamorous(View))
    in glamorous(View) (created by App)
    in App
Warning: Failed prop type: Invalid prop `style` of type `array` supplied to `Image`, expected `object`.
    in Image (created by glamorous(Image))
    in glamorous(Image) (created by App)
    in view (created by View)
    in View (created by glamorous(View))
    in glamorous(View) (created by App)
    in App
Warning: Failed prop type: Invalid prop `style` of type `array` supplied to `Text`, expected `object`.
    in Text (created by glamorous(Text))
    in glamorous(Text) (created by App)
    in view (created by View)
    in View (created by glamorous(View))
    in glamorous(View) (created by App)
    in App
🛠  Built ./my-command.js in 2239ms

alechp avatar Oct 03 '17 22:10 alechp

Yeah it gives error when rendering to sketch. I'll try to fix it later this week.

nitin42 avatar Oct 05 '17 06:10 nitin42

Well, this package depends on react-primitives for binding the aliases to the glamorous constructor. Seems like react-primitives relies on createClass method and the author has not updated that. As soon as he updates the codebase (with React 16), I'll fix this issue 😄

nitin42 avatar Oct 09 '17 05:10 nitin42