Nir Gazit
Nir Gazit
@peachypeachyy this should be [similar to OpenAI](https://github.com/traceloop/openllmetry/blob/747cf1887831591892a83fdbd4cbce681234f697/packages/opentelemetry-instrumentation-openai/opentelemetry/instrumentation/openai/shared/chat_wrappers.py#L353). You're right btw, we're missing these from the semantic conventions.
@dinmukhamedm happy for a contribution! It's a small one and I think @peachypeachyy is no longer working on it
Thanks @damianoneill! Will try to reproduce this. For the fastapi - you'll need to add the FastAPI instrumentation. Are you using our SDK?
No, I meant that we don't [instrument FastAPI currently](https://github.com/traceloop/openllmetry/blob/115ebea9b4d579b1d870de2d60a8fa59cea533f0/packages/traceloop-sdk/traceloop/sdk/tracing/tracing.py#L426), so you should do it yourself after initializing Traceloop. This is [really easy](https://opentelemetry-python-contrib.readthedocs.io/en/latest/instrumentation/fastapi/fastapi.html): ``` import fastapi from opentelemetry.instrumentation.fastapi import FastAPIInstrumentor from...
Hey @asaf, I'm going to delete this comment to avoid clutter in this issue as this is not the place to report new unrelated issues. I would love to assist...
Thanks for reporting @kshitiz-okahu! We're working on a fix
Thanks @michael-hhai! Do you mean that the auto-instrumentation doesn't work?
Yes, well known. That's why we have this: https://www.traceloop.com/docs/openllmetry/tracing/js-force-instrumentations It's indeed more of an inherent problem with Node.js, but hopefully will be fixed.
@michael-hhai I'm 90% sure it works (wanted to say 99% but maybe I need to be more modest)
Thanks! I think it's related to https://github.com/openai/openai-node/issues/903 A possible workaround can be - ``` import { register } from "node:module"; register("import-in-the-middle/hook.mjs", import.meta.url, { parentURL: import.meta.url, data: { include: ["openai"]}, });...