Missing storages' db_path attribute requirement

[Coder-DG]

trafficstars

At ghost.py line 298 Stash is trying to access the storage's db_path attribute. Since there's no demand that that attribute should reside in the storage, the program crashes due to an AttributeError.

[nir0s]

I don't quite understand what it means that there's no requirement. Every storage must implement a constructor which receives db_path. Yes, it's not "documented", but the tests will fail if you don't provide such an attribute.

[Coder-DG]

Well I thought it'd be a good idea to write that in the contribution page.

On Apr 6, 2017 12:30 AM, "Nir Cohen" [email protected] wrote:

I don't quite understand what it means that there's no requirement. Every storage must implement a constructor which receives db_path. Yes, it's not "documented", but the tests will fail if you don't provide such an attribute.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nir0s/ghost/issues/129#issuecomment-292092312, or mute the thread https://github.com/notifications/unsubscribe-auth/ADwAE2jESA8X_S6QbaF7e6vM4k4jYAflks5rtJSTgaJpZM4Mzc2D .

[nir0s]

That would be great.