nipype icon indicating copy to clipboard operation
nipype copied to clipboard

[FIX] mat 7.3 support for SPM.mat files

Open adamnarai opened this issue 1 year ago • 1 comments
trafficstars

Summary

Fixes #2162 Fixes #3432

List of changes proposed in this PR (pull-request)

  • Replace sio.loadmat with a load function specific for SPM.mat files, so it also supports >2 GB mat 7.3 HDR files
  • Fix MATLAB's test_run_interface which I also encountered while running the tests

adamnarai avatar May 23 '24 17:05 adamnarai

Codecov Report

Attention: Patch coverage is 5.00000% with 38 lines in your changes missing coverage. Please review.

Project coverage is 70.46%. Comparing base (e03ab6f) to head (bd0d585). Report is 187 commits behind head on master.

Files with missing lines Patch % Lines
nipype/utils/filemanip.py 2.77% 35 Missing :warning:
nipype/interfaces/spm/model.py 33.33% 2 Missing :warning:
nipype/interfaces/tests/test_matlab.py 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3650      +/-   ##
==========================================
- Coverage   70.83%   70.46%   -0.37%     
==========================================
  Files        1276     1277       +1     
  Lines       59320    59153     -167     
  Branches     9826     8590    -1236     
==========================================
- Hits        42019    41685     -334     
- Misses      16125    16340     +215     
+ Partials     1176     1128      -48     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 23 '24 17:05 codecov[bot]