nipype icon indicating copy to clipboard operation
nipype copied to clipboard

[WIP] FIX - AFNI Zeropad sets out_file

Open zachlindsey opened this issue 1 year ago • 3 comments
trafficstars

Summary

Fixes #3640 .

List of changes proposed in this PR (pull-request)

  • Remove name_template from ZeropadInputSpec, since it is useless if it is not a format string and the underlying command doesn't form outputs from the input name.
  • Implement a custom _list_outputs method to set the correct out file.

zachlindsey avatar Mar 20 '24 22:03 zachlindsey

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (edf7a4a) to head (bc4af2b). Report is 12 commits behind head on master.

:exclamation: Current head bc4af2b differs from pull request most recent head 6b81d26. Consider uploading reports for the commit 6b81d26 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #3641       +/-   ##
==========================================
- Coverage   63.44%       0   -63.45%     
==========================================
  Files         308       0      -308     
  Lines       40887       0    -40887     
  Branches     5655       0     -5655     
==========================================
- Hits        25942       0    -25942     
+ Misses      13909       0    -13909     
+ Partials     1036       0     -1036     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 20 '24 22:03 codecov[bot]

After trying out this fix for my workflow, I've realized that out_file needs to be an absolute path! Will fix.

zachlindsey avatar Mar 21 '24 02:03 zachlindsey

Made a suggestion. Haven't tested it, but if you commit and run locally, those tests should pass. They'll skip on CI.

effigies avatar Mar 21 '24 15:03 effigies