nipype icon indicating copy to clipboard operation
nipype copied to clipboard

[FIX]Deduplicate dcm2niix output

Open mauriliogenovese opened this issue 2 years ago • 1 comments
trafficstars

fix for #3579

mauriliogenovese avatar Oct 09 '23 16:10 mauriliogenovese

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 63.18%. Comparing base (682abac) to head (39b3a2c). Report is 70 commits behind head on master.

:exclamation: Current head 39b3a2c differs from pull request most recent head 45e8076. Consider uploading reports for the commit 45e8076 to get more accurate results

Files Patch % Lines
nipype/interfaces/dcm2nii.py 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3610      +/-   ##
==========================================
- Coverage   63.18%   63.18%   -0.01%     
==========================================
  Files         308      308              
  Lines       40809    40810       +1     
  Branches     5652     5652              
==========================================
  Hits        25784    25784              
- Misses      14013    14014       +1     
  Partials     1012     1012              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 09 '23 16:10 codecov[bot]

Apologies for the delay. Is it possible to write a test that reproduces the issue?

effigies avatar Mar 17 '24 14:03 effigies

I cannot write a test without providing images from a subject and I don't have a public dataset. Anyway the pull request simply removes any duplicate entry from the final file list, so it would be fine in this and any other similar case.

mauriliogenovese avatar Mar 21 '24 14:03 mauriliogenovese