dcm2niix - Do consider exit 1 to be an error

[yarikoptic]

trafficstars

Based on information in https://github.com/rordenlab/dcm2niix/issues/733#issuecomment-1646261249

Exit code 0 is for success, exit code 1 is the undefined error.

Handling of exit 1 as successful was added in 6ecd4a9fce3c9cf1ff23d5b895db319343ae0576 AKA 1.0.2~2^2~13

Closes #3592

[codecov[bot]]

Codecov Report

Patch and project coverage have no change.

Comparison is base (ca27e51) 63.17% compared to head (be5b908) 63.17%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3594   +/-   ##
=======================================
  Coverage   63.17%   63.17%           
=======================================
  Files         308      308           
  Lines       40813    40813           
  Branches     5654     5654           
=======================================
  Hits        25784    25784           
  Misses      14016    14016           
  Partials     1013     1013           

Files Changed	Coverage Δ
nipype/interfaces/dcm2nii.py	49.09% <0.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[effigies]

Should this be made configurable? If I recall, handling a non-error code 1 for HeuDiConv was the motivation, so it may be breaking some workflows to change this. If it's configurable here, HeuDiConv could add a flag.