nipype
nipype copied to clipboard
[WIP] enh: turn interface into callable
turning interfaces into a callable to support dask based operations.
If this is for Nipype 1.x, could you set the milestone to 1.1.4?
If this is for Nipype 2.0, could you set the target branch to dev/2.0 and the milestone to Nipype 2.0?
I think this should work in nipype 1.0 without much trouble. Therefore, I see under 1.0 anything that makes the jump between 1.0 and 2.0 easier but does not mean to actually implement 2.0.
Codecov Report
Merging #2724 into master will decrease coverage by
3.41%. The diff coverage is33.33%.
@@ Coverage Diff @@
## master #2724 +/- ##
==========================================
- Coverage 67.44% 64.02% -3.42%
==========================================
Files 340 338 -2
Lines 43164 43122 -42
Branches 5351 5350 -1
==========================================
- Hits 29110 27610 -1500
- Misses 13355 14445 +1090
- Partials 699 1067 +368
| Flag | Coverage Δ | |
|---|---|---|
| #smoketests | ? |
|
| #unittests | 64.02% <33.33%> (-0.79%) |
:arrow_down: |
| Impacted Files | Coverage Δ | |
|---|---|---|
| nipype/interfaces/base/core.py | 85.86% <33.33%> (-2.29%) |
:arrow_down: |
| nipype/interfaces/nilearn.py | 40% <0%> (-56.67%) |
:arrow_down: |
| nipype/utils/spm_docs.py | 25.92% <0%> (-44.45%) |
:arrow_down: |
| nipype/interfaces/freesurfer/base.py | 49.59% <0%> (-30.9%) |
:arrow_down: |
| nipype/utils/logger.py | 59.7% <0%> (-29.86%) |
:arrow_down: |
| nipype/algorithms/rapidart.py | 35.39% <0%> (-29.21%) |
:arrow_down: |
| nipype/interfaces/spm/base.py | 58.41% <0%> (-29.05%) |
:arrow_down: |
| nipype/utils/provenance.py | 55.73% <0%> (-28.99%) |
:arrow_down: |
| nipype/interfaces/fsl/model.py | 55.26% <0%> (-25.35%) |
:arrow_down: |
| nipype/testing/fixtures.py | 77.33% <0%> (-21.34%) |
:arrow_down: |
| ... and 45 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 39675df...3d347ad. Read the comment docs.
Anything left to this one?
Hi, just a reminder that the 1.1.8 release is targeted for January 28. Please let us know if you'd like to try to finish this up for that release.