nipype
nipype copied to clipboard
Nipype multiproc plugin modification to use GPU(s) as resources.
Fixes # .
Changes proposed in this pull request
- Workflow nodes that run on GPUs can be scheduled similar to that of CPU resources. The plugin args will now require additionally "n_gpus" for total no. of GPUs to use and "ngpuproc" for no. of threads to start on a single GPU.
it would be good to merge this with master and resolve the conflicts.
@schahid - is this something you can take care of? or should we take it over?
@satra - sorry for the delay in replying...as i am on holidays...yes sure you can take it over. thanks a lot.
just putting a note here that with the reorganization of this module in release 1.0, this will require some significant merge effort.
Foolishly enough, I took a shot at that some time last week.
https://github.com/nipy/nipype/compare/master...effigies:enh/gpu_management
Since it's @schahid's master branch, I don't want to push to it directly. If anybody wants to take ownership of this PR, they can push that branch to their own repo, and open a new PR. (Or @schahid can git merge my branch into their master and resume work on it, .)
@effigies :)
@schahid - would it be possible for you to take it on from @effigies changes?
Hi @satra and @effigies I have merged your branch into my master branch. Please let me know what else I should do? Thanks.
Codecov Report
Merging #2298 into master will decrease coverage by
0.23%. The diff coverage is47.02%.
@@ Coverage Diff @@
## master #2298 +/- ##
==========================================
- Coverage 66.66% 66.42% -0.24%
==========================================
Files 328 339 +11
Lines 42529 47398 +4869
Branches 5278 5317 +39
==========================================
+ Hits 28350 31485 +3135
- Misses 13500 15171 +1671
- Partials 679 742 +63
| Flag | Coverage Δ | |
|---|---|---|
| #smoketests | 50.66% <44.86%> (-0.13%) |
:arrow_down: |
| #unittests | 63.96% <40.54%> (-0.02%) |
:arrow_down: |
| Impacted Files | Coverage Δ | |
|---|---|---|
| nipype/pipeline/plugins/multiproc.py | 60.41% <47.02%> (-19.35%) |
:arrow_down: |
| nipype/interfaces/nilearn.py | 40% <0%> (-56.83%) |
:arrow_down: |
| nipype/interfaces/nitime/analysis.py | 43.15% <0%> (-36.85%) |
:arrow_down: |
| nipype/utils/nipype_cmd.py | 41.66% <0%> (-35%) |
:arrow_down: |
| nipype/testing/fixtures.py | 77.33% <0%> (-21.34%) |
:arrow_down: |
| nipype/pipeline/plugins/tools.py | 70.32% <0%> (-16.82%) |
:arrow_down: |
| nipype/algorithms/confounds.py | 51.71% <0%> (-15.6%) |
:arrow_down: |
| nipype/interfaces/freesurfer/base.py | 60.16% <0%> (-13.01%) |
:arrow_down: |
| nipype/interfaces/ants/registration.py | 67.04% <0%> (-6.04%) |
:arrow_down: |
| nipype/workflows/smri/freesurfer/autorecon2.py | 65.9% <0%> (-5.37%) |
:arrow_down: |
| ... and 96 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 88dbce1...1e1adc8. Read the comment docs.