mriqc icon indicating copy to clipboard operation
mriqc copied to clipboard

ENH: Creating an FSL-free version of MRIQC

Open NPann opened this issue 5 years ago • 12 comments

Replaces #807 , as I can't write that branch.

The plan is to minimize the dependency on FSL, and provide an alternative compute graph that is completely free of FSL. From #807, fixed MD5 sum check, IQM check and set ANTs seed.

NPann avatar Dec 14 '19 19:12 NPann

Codacy Here is an overview of what got changed by this pull request:


Complexity increasing per file
==============================
- mriqc/workflows/anatomical.py  1
         

See the complete overview on Codacy

oesteban avatar Dec 14 '19 20:12 oesteban

Not sure why the circleCI checks do not show up here. But passing the CICD on my fork as can be shown here.

NPann avatar Dec 16 '19 18:12 NPann

Adding comment to get notification when merged,

dorianps avatar Dec 22 '19 15:12 dorianps

@oesteban, happy new year! Any chance to get your inputs on this one?

NPann avatar Jan 06 '20 17:01 NPann

@oesteban, any chance to get your inputs one this PR? Or do you think we should just work from a fork?

NPann avatar Mar 17 '20 18:03 NPann

Hi @NPann, I have blocked 2h of my calendar next Tue 24th to finish this up. Sorry, I'm snowed under quite a long backlog. Having you guys working off of a fork without a stronger reason other than my inability to go through your contribution seems unfortunate, I'll try to be more responsive (and bring in people from the community to help put the project forward).

Just so you know, MRIQC will soon be migrated under https://github.com/nipreps/ as part of the migration to a more community-driven approach (see www.nipreps.org).

oesteban avatar Mar 20 '20 21:03 oesteban

BTW, I was checking the reports from https://circleci.com/workflow-run/a2f69a9d-cf02-4c1c-9a27-24deba6889a1 - please let me know if that is not correct.

oesteban avatar Mar 24 '20 16:03 oesteban

@oesteban , Thanks for the comment. I indeed screwed up something with the parsing of the USE_FSL env var. I think I got it right this time. CI report at https://app.circleci.com/pipelines/github/NPann/mriqc/21/workflows/b79c9ffb-564d-45d4-b192-24085e909cba

The FSL license does not seem to allow for commercial redistribution. I created a fsl free dockerfile as well and added bold and T1w tests with it (which should be the same as the docker image with FSL but USE_FSL=0, same md5 signatures). Updated circleCI to publish that image to dockerhub as well. If all look good, I can update the doc accordingly.

NPann avatar Mar 28 '20 21:03 NPann

Thanks @oesteban.

  • I checked the segmentation and the main discrepancy seems to be for sub-50137. Any clue where to start to fix this?
  • Regarding the _no_fsl jobs at CircleCI. If you use the new docker image with USE_FSL=0 that's very much the same than the __fsl_free_image job. Should I just remove the _no_fsl job?
  • Re the classifier, I think this is something we are pretty well equipped to do at Flywheel. I'll request access to ABIDE, download ds030 (this version is the right one?) and dig into what we can do. Likely it requires to fix the segmentation issue aforementioned before.
  • I'll split the fMRI into another PR.

NPann avatar Apr 03 '20 21:04 NPann

Was this superseded by #842?

effigies avatar Jan 05 '21 12:01 effigies

Was this superseded by #842?

I don't think so. #842 was addressing the FMRI path. This one was re-focused on anatomical scans but still had a few issues as mentioned by Oscar. Unclear about path forward here.

NPann avatar Jan 05 '21 16:01 NPann

Ah, thanks for clarifying. I would say the next steps would probably be to merge current master (or rebase, if that's your preference), make sure tests are passing, and then re-ping.

But I'm not really deeply involved in MRIQC (just doing some maintenance), so @oesteban may have more specific thoughts.

effigies avatar Jan 05 '21 17:01 effigies

It seems this is finally happening - only one remaining use of BET in the anatomical workflow (to generate the "outskin" mask).

After that, the only action remaining is replacing MELODIC -- maybe @eilidhmacnicol has the humor to take a stab at it and replace it with some nilearn ICA.

Closing this PR as it has become stale. Apologies for my inaction over time @NPann .

oesteban avatar Mar 29 '23 08:03 oesteban