nimrossum

Results 103 comments of nimrossum

Thanks, I will try that when I find some more time to test it. It's a neat idea though, that potentially can save you from accidentally DDoS'ing your endpoints...

> This eslint rule ("react-hooks/exhaustive-deps": "warn") may help you prevent this kind of thing happening: > > https://github.com/facebook/react/blob/master/packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.js#L516 This rule actually does the opposite for me, it causes these sorts...

@Rundik I did this as a work around: ```javascript const buffer = await new Promise((resolve, reject) => image.getBuffer(jimp.MIME_PNG, (error, buffer) => { if (error) reject(error) else resolve(buffer) }) ) ```...

There are also some other issues, for example that we don't have a way for specifying whether a legend label should be formatted as a date, see [here](https://github.com/git-truck/git-truck/pull/439#pullrequestreview-924530141), so I...

I also thought about whether the metrics should be scoped to the selected folder? The min/max i mean.

@emiljapelt Is this implemented?

I talked to @emiljapelt who says this is partially implemented, so I will close this issue

Yeah, the last changed view is definetely problematic. We are working on finding better methods for this view. Amelia Wattenberger uses a pretty neat scale, that is skewed: ![image](https://user-images.githubusercontent.com/1959615/172934942-74c5b0d1-2118-4f76-a355-52c84f9e36df.png) https://githubnext.com/projects/repo-visualization/

We use the colors provided by https://github.com/ozh/github-colors along with extension lookup using this package: https://github.com/jonschlinkert/lang-map After looking through https://github.com/jonschlinkert/lang-map/blob/master/lib/exts.json it seems that ipynb is not listed in here. We could...

I just found this package: https://github.com/blakeembrey/language-map/ Which seems to have ipynb listed here: https://github.com/blakeembrey/language-map/blob/main/languages.json We could experiment with changing to using that package instead.