Nim icon indicating copy to clipboard operation
Nim copied to clipboard

Published 20 hours ago • verified publisher icon nim-lang

Fixes #20348; only respect the recursion limit if the symbol's generic type has been generated by the compiler

Open deech opened this issue 3 years ago • 2 comments
trafficstars

deech avatar Sep 17 '22 13:09 deech

It looks like this change is causing timeouts on CI. Can I get some help diagnosing which test is taking too long? I don't know where to look for test timing logs.

deech avatar Sep 17 '22 14:09 deech

Now that CI passes unless people have an issue with the new flag this an incremental improvement that can be merged. In the long term it would be good to talk about

  • a re-design that avoids recursionLimit
  • setting the recursion limit to 2, I'm not sure what the difference is between bailing out at 2 vs. 100.

deech avatar Sep 18 '22 20:09 deech

This PR can be merged. We talked about it on Discord and Araq was good with this change.

deech avatar Sep 22 '22 18:09 deech

Thanks for your hard work on this PR! The lines below are statistics of the Nim compiler built from be4bd8a0edd527b24679372b8cb9d2afa548056d

Hint: mm: orc; threads: on; opt: speed; options: -d:release 164064 lines; 14.425s; 842.332MiB peakmem

github-actions[bot] avatar Sep 22 '22 18:09 github-actions[bot]