html2canvas icon indicating copy to clipboard operation
html2canvas copied to clipboard

Published 20 hours ago • verified publisher icon niklasvh

Correct dereferencing of `createFontStyle` return value

Open ohaibbq opened this issue 3 years ago • 6 comments
trafficstars

Summary

This PR fixes the following bugs:

  • [x] Closes #2775
  • [x] Closes #2769
  • [x] Closes #2691
  • [x] Closes #2596
  • [x] Closes #2087
  • [x] Closes #1667
  • [x] Closes #1888

Test plan (required) Test case: https://codepen.io/ohaibbq/pen/dyZJBNx

Code formatting

Please make sure that code adheres to the project code formatting. Running npm run format will automatically format your code correctly.

ohaibbq avatar Feb 18 '22 00:02 ohaibbq

I hope this gets merged soon

anshumanv avatar Sep 14 '22 08:09 anshumanv

Any tentative timeline to merge this one ?

uncloak avatar Sep 28 '22 08:09 uncloak

Any news on this? Text currently shows up completely misaligned

joanvf avatar Nov 08 '22 15:11 joanvf

I wouldn't recommend using this fork in your apps, as I'm less likely to do any maintenance than the repo owners here. If y'all can verify that it solves the issue you're seeing, it might move getting this merged along.

@joanvf @uncloak @anshumanv

 yarn add https://github.com/ohaibbq/html2canvas\#dan/font-style

ohaibbq avatar Nov 08 '22 18:11 ohaibbq

same questions, it should be merge

rsq1259 avatar Nov 17 '22 08:11 rsq1259

@niklasvh hello, any updates ?

monkeycatdog avatar Feb 23 '23 09:02 monkeycatdog