html2canvas icon indicating copy to clipboard operation
html2canvas copied to clipboard

fix the inconsisencies of HTML element with both box-shadow and border-radius

Open hybtalented opened this issue 5 years ago • 6 comments

Summary

This PR fixes the unexpect rendering of HTML element with box-shadow and border-radius styles. It also improve the performance of box-shadow with inset property.

here is the contract while the issues has been sovled: no border origin origin html without border no border render render by html2canvas without border border origin origin html with border no border render render by html2canvas with border Closing issues

Fixes #1987 maybeFixed #1856 (I can't assess the jsfiddle, so it not clear whether it was fixed.)

hybtalented avatar Sep 27 '20 08:09 hybtalented

Summary

This PR fixes the unexpect rendering of HTML element with box-shadow and border-radius styles. It also improve the performance of box-shadow with inset property.

no border origin origin html without border no border render render by html2canvas without border border origin origin html with border no border render render by html2canvas with border

Closing issues

Fixes #1987 maybeFixed #1856 (I can't assess the jsfiddle, so it not clear whether it was fixed.)

It looks like the pictures have been down. The effect of the changes can be test in the test page http://localhost:8080/tests/reftests/background/box-shadow.html

hybtalented avatar Oct 23 '20 02:10 hybtalented

@niklasvh could you please merge this one :) That would be great

trollr avatar Jun 10 '21 07:06 trollr

@niklasvh This solution works well. Could you merge this?

abdurrahmanyildirim avatar Sep 08 '21 11:09 abdurrahmanyildirim

hi i need this, any way to get a copy of a compiled JS file for this fork?

cyan-2048 avatar Dec 23 '21 07:12 cyan-2048

I'd like this merged too!

makinori avatar Feb 18 '22 20:02 makinori

I'd like this merged too, would you have any schedule to merge it.

Mamezou-zhang-yong avatar Aug 11 '22 10:08 Mamezou-zhang-yong

@niklasvh ?

bastienlemaitre avatar Jan 13 '23 10:01 bastienlemaitre

I tried this branch and the shadows still look pretty strangely, but it's better. However the "maybefix" part is not fixed.

Inviz avatar Mar 02 '23 09:03 Inviz