github-rebase-bot icon indicating copy to clipboard operation
github-rebase-bot copied to clipboard

Published 20 hours ago • verified publisher icon nicolai86

If PR is rejected, automatically add Changes Needed label

Open awitherow opened this issue 8 years ago • 4 comments
trafficstars

Also notify the creator?

  • slack channel ?
  • comment in PR?

awitherow avatar Feb 23 '17 09:02 awitherow

@awitherow can you describe in more detail what you mean by "rejected"?

nicolai86 avatar Mar 27 '17 16:03 nicolai86

  1. either by a reviewer
  2. a failing test.

Those were my two ideal cases. Thoughts?

awitherow avatar Mar 27 '17 20:03 awitherow

Thanks for the clarification.

I'm not sure how much noise this would generate, as e.g. branches which are not yet ready for review will probably have lots of failing tests. Do you think it's a good idea to perform these actions before the author declares her branch ready to be reviewed?

nicolai86 avatar Mar 28 '17 16:03 nicolai86

Nope, only if the review needed label is present.

awitherow avatar Mar 29 '17 13:03 awitherow