Nick Taylor

Results 265 comments of Nick Taylor

It looks like there are Canary E2E tests failing in your PR @ascorbic.

Thanks for reporting this! Just taking a peek at this.

Hi @ShuPink, is this still an issue for you? We've made a lot of changes since this issue was opened originally.

So far, what's in the PR is the reverted commits @mcansh mentioned in #3092 that from the [experimental-netlify-edge](https://github.com/remix-run/remix/tree/experimental-netlify-edge) branch and I merged latest of the `dev` branch.

~@mcansh, I'm currently adding the updated Edge template files, and I noticed that it looks like our template is the only one currently using `hydrateRoot` aside from the playground example...

I'm going to go with @mcansh's suggestion for testing this out locally as it's a bit of a unique situation as we're not just testing out the template. [From Discord](https://discord.com/channels/770287896669978684/940264701785423992/972240625078517880):...

> Just as a heads up, @jacob-ebey found a way to get Netlify Edge working purely through the template and without modifying the compiler. > > So we should stop...

> @nickytonline https://github.com/remix-run/remix/pull/3117 is now merged, so I think it would be a good idea to rebase this PR onto latest dev & resolve conflicts. > > We can see...

Thanks for all the great feedback @MichaelDeBoey! It's much appreciated as I'm still pretty new to Remix. I'm back on this today. 😎