Nick Taylor

Results 252 comments of Nick Taylor

> @nickytonline will you try it again with iOS Safari and see if the window opens now? Argh. Still no dice. If you have an Android phone, I can dig...

~Just looking at some flaky tests~ fixed! ``` 4 flaky [chromium] › star-search.spec.ts:4:5 › StarSearch (Logged Out Experience) ────────────────────── [firefox] › star-search.spec.ts:4:5 › StarSearch (Logged Out Experience) ─────────────────────── [webkit] ›...

> There are some things I'm not clear on, and I've left a couple of comments. Noteably, it's not allowing me to use it when logged in and the LI...

> Is this what we intend the tweet to look like? It doesn't really give the viewer information about what the prompt was unless you're looking at the url. >...

> This is what I get for LI > > > Seems like it's taking too long to load. Gotcha. So it is working in that it's doing what it's...

The logged in experience and logged out experience should be fine now. I fixed the one time only prompt for a guest @BekahHW.

For the OG image, I think it's Twitter caching it from the deployment preview before we had the shared prompt OG image. This is what I get when I share...

I'm still investigating why the URL isn't shortened via https://github.com/open-sauced/app/pull/3324/files#diff-4e4544e2a158050d1656e7d4abaa1d7652c416028e87eb88f570db12ac922b21R241 . Is it because it's a deployment preview @brandonroberts? ```typescript useEffect(() => { if (!promptMessage) { return; } const promptUrl...

There is no design for this at the moment. I've created a proof of concept in #3324. This is a stretch goal but doable. I think there's the possibility of...

Adding @bdougie's comments here: > I'd love to see us reuse elements from other places. > > Gemini uses a share icon. > > > > OpenSauced Highlights already have...