Nicky McCurdy

Results 473 comments of Nicky McCurdy

Based on the progress in #17 I feel like this doesn't need to be a blocker anymore so we can focus on Koa 2 (though I'd still like to fix...

@nfantone Would you agree with having one test file per file in lib with a `.test.js` extension in the same directory? This is what Jest generally recommends and I like...

I know that's typical, Jest supports both conventions. The nice thing about `*.test.js` is your tests are first class citizens right next to your source files, it's easy to see...

Besides `*.test.js`, Jest also supports `__tests__` directories. There are two options: one monolithic directory in the root of the project (what we're doing) and one `__tests__` directory inside *each* source...

I don't think conflicts would be an issue since eslint has its own section, the conflicts would likely be above the eslint config and still happen either way. I believe...

Whoops looks like I broke coverage on the listen function, I'll write a small test for it and wrap this up reorganizing the test files soon.

I fixed the directory structure, I'll ask for another review after I add the missing `app.listen()` test.

@ChiragRupani Would you be interested in merging these packages? Do you think it would be better than keeping them separate?

Is Chromium edge the default for new Windows 10 installations yet? Maybe we should wait until then and replace this package with @ChiragRupani's, unless people plan on needing to keep...

Is this on the same machine? If not, note that Edge is not supported on Windows Server.