A parameter is incorrectly ignored

[RussBaz]

The following snippet causes SwiftFormat to break the code:

func urlTestContains(path: String, strict _: Bool = true) -> Bool {
    let path = if path.hasSuffix("/") { path } else { "\(path)/" }

    return false
}

It does not detect that the path variable is used, and it will insert_ to the function signature.

I am sorry I could not describe the issue any better and could not verify if it was previously reported. Please have a look.

I am using swiftformat version 0.53.8.

Thank you.

[calda]

Should be fixed by https://github.com/nicklockwood/SwiftFormat/pull/1687

[nicklockwood]

@RussBaz fix landed in 0.53.9

[RussBaz]

Hi again. It seems like this issue has resurfaced for me. I am using 0.54.3. Can you check this?

[calda]

I can't reproduce this issue with the func urlTestContains sample code above, can you share new sample code that demonstrates the problem?

[RussBaz]

This seems to reproduce my problem:

enum Sample {
    func invite(lang: String, randomValue: Int) -> String {
        let flag: String? = if randomValue > 0 { "hello" } else { nil }

        let lang = if let flag { flag } else { lang }

        return lang
    }
}

lang will be incorrectly replaced with lang _ in the function signature.

[calda]

Thanks for the sample code, here's a fix: https://github.com/nicklockwood/SwiftFormat/pull/1815