docker-rails-example icon indicating copy to clipboard operation
docker-rails-example copied to clipboard

Published 20 hours ago • verified publisher icon nickjj

feature: cleanup tmp PID file

Open philihp opened this issue 7 months ago • 2 comments

I believe this might make the repo a little more resilient to (my) bad improper container shutdown habits, would you accept this upstream?

philihp avatar Apr 23 '25 20:04 philihp

Hi, yep this was brought up in https://github.com/nickjj/docker-rails-example/issues/65. A long time ago I opened an issue about this in Rails at https://github.com/rails/rails/issues/52558 too.

Deleting the old pid before Puma boots feels like probably the safest bet since the pid will exist once the container starts which will handle the LSP case or whatever else.

I do wonder about the env var approach though.

nickjj avatar Apr 23 '25 21:04 nickjj

Oh neat, yeah I agree... it does look like that env var to tmpfs is actually a better solution. I guess this PR would resolve #65 then?

philihp avatar Apr 23 '25 23:04 philihp