docker-rails-example icon indicating copy to clipboard operation
docker-rails-example copied to clipboard

bugfix - image wont show when using local activestorage

Open mirzalazuardi opened this issue 1 year ago • 2 comments

Hi @nickjj,

I found the issue when i using activestorage with disk service, and got me errors when i check on the image url. The image also wont show on the web. But i already found a solution for this. which is to add some dependencies. Please check my PR

Thanks

mirzalazuardi avatar Mar 30 '24 05:03 mirzalazuardi

Hi,

Yep, ActiveStorage requires system level dependencies and libvips is the way to go. I've added that package to my own personal projects that use it.

The concern here is not everyone uses ActiveStorage and including libvips increases the Docker image size. If we wanted to make ActiveStorage work out of the box for this example project it would require also adding new JavaScript dependencies for direct upload support and modifying the app JS code to include it.

Maybe we can keep this PR open to see if others are interested in having ActiveStorage be included by default. If there's demand for that, I'd be happy to add it.

nickjj avatar Mar 30 '24 13:03 nickjj

Thanks... happy to help & contribute to your project

mirzalazuardi avatar Apr 02 '24 07:04 mirzalazuardi