keymap-editor icon indicating copy to clipboard operation
keymap-editor copied to clipboard

Support additional OSX icons

Open mattrayner opened this issue 1 year ago • 5 comments
trafficstars

Hi, it would be cool if we could show OSX icons for additional keys:

  • Brightness Up (pause break)
  • Brightness Down (scroll lock)

Im happy to contribute a PR for this but have seen the closed source change you are making...

mattrayner avatar May 03 '24 15:05 mattrayner

Good call, I should include the brightness keys. I'm using FontAwesome currently and taking a quick peek at the collection it seems that brightness up/down aren't included in the free set. I've had other such limitations and have been meaning to explore other icon sets so this is just more justification for that.

Could you clarify what you mean with the pause break and scroll lock in your parentheses? I'm looking at the ZMK Keycodes: Display table which just references HID codes. I'm on my MacBook where brightness are dedicated keys (touchbar, actually, bleh), are there fullsize external keyboards where those functions share the same keys?

nickcoutsos avatar May 03 '24 17:05 nickcoutsos

For OSX you typically use the keys SLCK for brightness down and PUSE_BREAK for brightness up as those keys are mapped by default at the OS level to brightness up and down

mattrayner avatar May 06 '24 13:05 mattrayner

Personally I'm moving to keymap-editor from Oryx and am just noting the 'differences', originally with the plan to commit back and improve, still happy to do that onto this repo if you wanted to then pull those changes forward onto your release?

mattrayner avatar May 06 '24 13:05 mattrayner

For example, C_NEXT and C_PREV would be good to have an icon for:

image

mattrayner avatar May 06 '24 13:05 mattrayner

Backlight controls could too:

image

Along with the Bluetooth control icons

Have you looked at material design icons (MDI) Material Design Icons

mattrayner avatar May 06 '24 13:05 mattrayner