Nicholas Rice

Results 27 comments of Nicholas Rice

Here are a few ways I think we can fix this problem. The changes would affect the following components, all of which use ElementInternals (and form association) and focus delegation:...

Thank you @calebdwilliams!! I can't believe it's that simple of a fix; I'd completely forgotten about that argument. I'll take a stab at implementing the mixin you linked too, it...

This looks great to me - it sets up a framework for describing more nuanced interaction guidelines. Good idea!

This looks like a FormAssociated issue. ElementInternals.setValidity is being called with a validity object from the native input, but the interface signatures are not completely compatible: https://developer.mozilla.org/en-US/docs/Web/API/ElementInternals/setValidity vs https://developer.mozilla.org/en-US/docs/Web/API/ValidityState. It...

Thanks for reporting @m-akinc. It looks like this is only affecting v1, [no repro v2](https://stackblitz.com/edit/typescript-6updax?file=index.ts,index.html).

Thanks for putting this up @impxd. I did some more digging because the behavior didn't make any sense to me, and it looks like the core of this issue is...

How is this CSS variable set? In the scenario you're describing, the change handler would be invoked prior to making any necessary DOM updates. Thats okay though, because the strategy...

The component's view will be bound and appended to the host element / shadowRoot during the connectedCallback. You should have access to the size of the host element after super.connectedCallback....

Can you put together a min-repro of your scenario, or update the above stackblitz so it is reflective of your scenario? I don't think I'm understanding all the constraints.

First, I think this all generally sounds like a good set of changes. In practice, I've seen a few projects where the existing `DesignToken` is assembled into a structure resembling...