Nícholas André

Results 111 comments of Nícholas André

@joesnellpdx Yeah this would be great. I ran into some issue setting up TS but I can revisit this in 2022.

I like the idea of passing an element instead of a selector to `Accordion` and also make `Accordion` handle only one element at a time instead of a collection of...

Sorry, @lea10up didn't mean to lose context, I was simply moving all issues to this repo (and linking to the original ones) because all of the front-end components will live...

So I believe the main issue here is how the package is being bundled. Toolkit ships this package as a single commonjs file, and as far as I know it...

@Antonio-Laguna A single entry point or a single bundled file? I was reffering to having something like this: dist/ dist/index.js dist/utils/index.js dist/utils/func1.js dist/components/index.js dist/components/comp1.js with the entry point being dist/index.js....

@dmtrmrv Would you mind try adding a few e2e tests? You can follow the structure of the existing e2e tests, essentially you can create a new "project" with an expected...

> I created a protorype for this in a local scaffold. This here is the PHP we would need to add to the scaffold for this to work: > >...

Yes you're right. I don't know if there was a particular reason we're overwriting those filenames. Also that code is also not great bc it mutates the parameter (which is...

I'm fine with running a build after shutting down hot mode. I agree that showing what's going on would be ideal. Something along the lines of "cleaning up HMR and...

Discussed in 10up-toolkit council meeting and we agreed to relax this rule.