nhibernate-core
nhibernate-core copied to clipboard
nhibernate
Added support for the CancelQuery() method in IStatelessSession
On GitHub action, AFAIK we are running SQL Server under Linux, and we seem to hit dotnet/SqlClient#109. It has been fixed in Microsoft.Data.SqlClient 2.0, but we are using System.Data.SqlClient, which is unlikely to be fixed, since Microsoft has announced it will go on developing only Microsoft.Data.SqlClient.
Should we switch Sql Server tests to Microsoft.Data.SqlClient? Well, ideally I think we should go on testing System.Data.SqlClient under .Net Framework, but test Microsoft.Data.SqlClient under net6.0.
@hazzik, it seems this cancel test freezes Oracle test suit. (Maybe Oracle does not support Cancel...) The NHibernate agent on TeamCity seems gone. Can you check what is going on please?
@fredericDelaporte
The NHibernate agent on TeamCity seems gone. Can you check what is going on please?
My Credit Card in Azure is expired and MS has shut down the environment. That is why.
Should we switch Sql Server tests to Microsoft.Data.SqlClient?
We should at least add it to the test suit. Maybe we test it in both platforms?
My Credit Card in Azure is expired and MS has shut down the environment. That is why.
Ok, I've re-enabled my Azure subscription. The agent is back online, but now it is not authorized :(
The agent is back online, but now it is not authorized :(
It seems all you have to do is to click Authorize on this page https://teamcity.jetbrains.com/agents.html?tab=unauthorizedAgents (I see no such button but I might not have all required permissions)
I don’t have the button either. Need to contact Jetbrains people.
On Wed, 13 Jul 2022 at 6:33 PM, Roman Artiukhin @.***> wrote:
The agent is back online, but now it is not authorized :(
It seems all you have to do is to click Authorize on this page https://teamcity.jetbrains.com/agents.html?tab=unauthorizedAgents ( I see no such button but I might not have all required rights)
— Reply to this email directly, view it on GitHub https://github.com/nhibernate/nhibernate-core/pull/3074#issuecomment-1182822100, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABDLF6GGIW47ZY33YUKUPLVTZPMVANCNFSM5Y7MFYPA . You are receiving this because you were mentioned.Message ID: @.***>
I've raised a ticket to solve it. I don't have permission to change pool nor authorize agents. Hopefully it will be resolved soon. Sorry for the delays - I don't have good access to a workstation.
Ok, agent is back. I've also increased tier for the VM, so builds are slightly faster now.
@hazzik I checked locally on Oracle 19c: test passed. Perhaps the problem is that on TC Oracle 18c. In release 18c, "Manual completion of unmanaged queries" was added (https://docs.oracle.com/en/database/oracle/oracle-database/18/newft/new-features.html#GUID-EFC832BE-DC2C-4997-8C38-8A9E27A4FFC4). But from what version 18.x?
I'll try installing 18.3 on my machine and run the test: if it passes then I have no idea why TC failed.
On 18.3 (on my local server) it works fine, all tests passed. The only difference from TC is that I have Oracle on Windows.
On 18.3 (on my local server) it works fine, all tests passed. The only difference from TC is that I have Oracle on Windows.
"Canceled in 360m - Oracle" misled me, I checked locally for nothing. At the TC: all test(NHibernate Oracle Managed 32) pass.
"Canceled in 360m - Oracle" misled me
Why misled? There is clearly some issue with Git Hub Action build (Oracle on Linux) - https://github.com/nhibernate/nhibernate-core/runs/7643016174?check_suite_focus=true
On "Git Hub Action" yes but not on teamcity(I initially thought that the assembly hung on the TC due to deadlock). So "misled me" means that the problem is not where I thought it was.
It makes for a central point for checking database limitations, which may help when we wish to check if some of these limitations do no more apply. Tests skipped directly inside them for some databases are harder to spot.
I think the problem is that the implementation relies on the batcher implementation. And SqlServer and Oracle use custom batcher implementation that might behave differently.