nhibernate-core icon indicating copy to clipboard operation
nhibernate-core copied to clipboard

Published 20 hours ago • verified publisher icon nhibernate

Avoid double param type guessing and better NULL parameter handling in LINQ

Open bahusoid opened this issue 4 years ago • 8 comments

And added test cases for #1166

bahusoid avatar Apr 07 '21 10:04 bahusoid

@bahusoid please resolve conflicts.

Also as I understand some changes needs to be reverted from 5.3.9

hazzik avatar Jul 05 '21 09:07 hazzik

I believe it would also need changes similair to https://github.com/nhibernate/nhibernate-core/pull/2836

bahusoid avatar Jul 05 '21 09:07 bahusoid

please resolve conflicts. Also as I understand some changes needs to be reverted from 5.3.9

Done

bahusoid avatar Jul 05 '21 15:07 bahusoid

There is a conflict with #2964 to resolve.

fredericDelaporte avatar Apr 18 '22 12:04 fredericDelaporte

Hopefully I've resolved the conflict correctly. @maca88 and @bahusoid could you please check.

hazzik avatar Jul 21 '22 03:07 hazzik

From my point of view the conflict was correctly resolved. Even if the modification in GetCharsGenerator class fixes the tests, I would still leave the change from #2964 as there could be other cases (e.g. with user defined hql functions) for which we don't have tests.

maca88 avatar Jul 23 '22 20:07 maca88

It seems some of the changes no longer needed. I need to look at it more closely when I have time...

bahusoid avatar Aug 08 '22 06:08 bahusoid

#2964 implements most of the logic of original PR. Now this PR is transformed in parameter handling improvement so changed the name.

bahusoid avatar Aug 11 '22 16:08 bahusoid