NGOWorld icon indicating copy to clipboard operation
NGOWorld copied to clipboard

Fixes for card overflowing issue

Open rohitroy-github opened this issue 3 years ago • 2 comments

Fixes Issue

**My PR closes #502 **

Changes proposed

What were you told to do ?

I was told to fix the issue of Club card overflowing at the bottom of the page. This was the issue screenshot !

Screenshot (122)

What did you do ?

I made some component changes and added a few div to contain the issue and changed 'postition' variant for them. I also had to change the padding and gapping for the card from % to px and eliminate auto calculation for all the responsive modes !


Check List (Check all the applicable boxes)

  • [X] My code follows the code style of this project.
  • [X] This PR does not contain plagiarized content.
  • [X] The title and description of the PR is clear and explains the approach.

Screenshots

image

image

image

rohitroy-github avatar Oct 23 '22 05:10 rohitroy-github

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
milan ✅ Ready (Inspect) Visit Preview Oct 23, 2022 at 5:25AM (UTC)

vercel[bot] avatar Oct 23 '22 05:10 vercel[bot]

I tried to apply some changes, @IAmTamal have a look >

That's in 100% screen resolution > Change you wanted >

Screenshot (137)

Originally >

Screenshot (138)

I personally feel that the previous one looked better. Lemme know which one should I keep ?

rohitroy-github avatar Oct 23 '22 09:10 rohitroy-github