ngx_http_hmac_secure_link_module icon indicating copy to clipboard operation
ngx_http_hmac_secure_link_module copied to clipboard

$secure_link_hmac_expires variable not filled

Open SmaugPool opened this issue 3 years ago • 0 comments

During my tests, the $secure_link_hmac_expires variable value was overridden by the $secure_link_hmac_token one.

It might be due to the goto not_found when it is negative:

  228             if (expires < 0) {
  229                 goto not_found;
  230             }
  231 
  232             ctx = ngx_pcalloc(r->pool, sizeof(ngx_http_secure_link_ctx_t));
  233             if (ctx == NULL) {
  234                 return NGX_ERROR;
  235             }
  236 
  237             ngx_http_set_ctx(r, ctx, ngx_http_hmac_secure_link_module);
  238 
  239             ctx->expires.len = value.len;
  240             ctx->expires.data = value.data;

Or to the initialization issue fixed in this fork else:

https://github.com/area9innovation/ngx_http_hmac_secure_link_module/commit/6ac01a27caac0c78c667cf8e078027f11ca433e0

SmaugPool avatar Sep 21 '22 02:09 SmaugPool