tools icon indicating copy to clipboard operation
tools copied to clipboard

linting modules/subworkflows - add failure when no snapshots for versions

Open maxulysse opened this issue 1 year ago • 3 comments

Description of the bug

the versions of tools is highly reproducible on docker/singularity, but it's often a lottery in conda. I'd like a linting test that ensure we snapshot for modules, either:

  • process.out.versions
  • process.out (only since it contains versions)

we snapshot for subworkflows either:

  • workflow.out.versions
  • workflow.out (only since it contains versions)

Command used and terminal output

No response

System information

No response

maxulysse avatar Feb 29 '24 15:02 maxulysse

Note: For subworkflows, we don't always use modules, so only a warning. For subworkflows, snapshotting versions could be empty in some tests if we skip all the tools from said subworkflow.

maxulysse avatar Feb 29 '24 15:02 maxulysse

Related PRs:

  • https://github.com/nf-core/modules/pull/4418
  • https://github.com/nf-core/modules/pull/4828
  • https://github.com/nf-core/modules/pull/4831
  • https://github.com/nf-core/modules/pull/4925

maxulysse avatar Feb 29 '24 15:02 maxulysse

Wasn't it an issue for bumping modules since then the snapshot wouldn't match ? If you checked if the output matched a regex, then that should be fine too for autobumping modules?

mahesh-panchal avatar Feb 29 '24 15:02 mahesh-panchal