tools icon indicating copy to clipboard operation
tools copied to clipboard

Linting message not 100% correct

Open apeltzer opened this issue 3 years ago • 1 comments

Description of the bug

Lint error says I have to update Samtools:

image

However, the conda handle has two different recipes listed:

image

Command used and terminal output

nf-core lint 
(on latest smrnaseq pr that adds fastp functionality)

System information

Independent of all of this nf-core/tools 2.6

apeltzer avatar Oct 10 '22 08:10 apeltzer

I can reproduce it on the master-branch, but it is just a warning:

╭─ [!] 11 Module Test Warnings ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│                          ╷                                    ╷                                                                                           │
│ Module name              │ File path                          │ Test message                                                                              │
│╶─────────────────────────┼────────────────────────────────────┼──────────────────────────────────────────────────────────────────────────────────────────╴│
│ bowtie_map_mirna         │ modules/local/bowtie_map_mirna.nf  │ Conda update: bioconda::samtools 1.13 -> 1.19.2

I wonder if it isn't fair enough that the linter points out that there is a new version of samtools?

asp8200 avatar Mar 18 '24 09:03 asp8200