modules icon indicating copy to clipboard operation
modules copied to clipboard

Add CODEOWNERS

Open edmundmiller opened this issue 5 years ago • 8 comments

Closes #86

edmundmiller avatar Dec 09 '20 16:12 edmundmiller

Alright this is ready to review. I've gone through all of the modules and added anyone in the meta file to the codeowners. If they didn't have a specific author, I just marked them as TODO and maintainers can PR, or comment here if they want them. I have a few lines I'd like opinions on.

*       @drpatelh 
.github/workflows @Emiller88 
tests/ @Emiller88 

I think @drpatelh should be the default owner on all of them for now. I'd also like to help maintain the tests and the CI for this repo, I may pick up some orphan modules also.

I think this will make the review process for changes quicker in the future, I think the notifications on this repo might get noisy in the future.

If anyone else wants to toss their name into anything feel free to drop a comment.

edmundmiller avatar Dec 10 '20 18:12 edmundmiller

Is this still a thing? How would we keep this file up-to-date?

grst avatar Aug 03 '21 14:08 grst

I like this idea Is there a way to scrape the meta.yml files to update this codeowner file via a github action for example?

maxulysse avatar Sep 13 '21 12:09 maxulysse

I think this would be a big boost for keeping things maintained.

I think we could probably get away with a script to write the original one, then update it from there?

https://github.com/marketplace/actions/github-codeowners-validator

This looks like it'd keep the manual additions in check. I think there's going to be too many one off rules to maintain it automatically.

edmundmiller avatar Sep 13 '21 19:09 edmundmiller

This might get us started though https://github.com/marketplace/actions/author-to-codeowners

edmundmiller avatar Sep 13 '21 19:09 edmundmiller

When we have a Github Action updating codeowners, are we better off than having a github action that reads the meta.yml and directly assigns reviewers?

@drpatelh additionally had the idea to randomly assign reviewers to PRs, which would be particularly useful for new modules.

grst avatar Sep 14 '21 07:09 grst

@Emiller88 where are we with that PR? Shall we close it?

maxulysse avatar Oct 10 '22 12:10 maxulysse

I think this needs to be autogenerated at this point with nf-core tools

edmundmiller avatar Oct 10 '22 13:10 edmundmiller

Hi there!

We've noticed there hasn't been much activity here. Are you still planning on working on this? If not, you can ignore this message and we'll close your PR in about 2 weeks

Cheers the nf-core maintainers

matthdsm avatar Mar 06 '23 14:03 matthdsm

Hot take: What if we move this to tools? Since I think it's never going to be maintainable without tools.

edmundmiller avatar Mar 06 '23 22:03 edmundmiller

I have no stakes in this, just the part of the cleaning crew 🤷🏻 @maxulysse , @drpatelh ?

matthdsm avatar Mar 07 '23 08:03 matthdsm

Love @Emiller88 's idea

maxulysse avatar Mar 07 '23 08:03 maxulysse

Hot take: What if we move this to tools? Since I think it's never going to be maintainable without tools.

Hi @Emiller88, if you want to move this, can you do so?

matthdsm avatar Mar 22 '23 07:03 matthdsm

Supersed by #4161

muffato avatar Oct 19 '23 22:10 muffato