modules icon indicating copy to clipboard operation
modules copied to clipboard

Updated a bunch of modules that failed nf-test because of the generation of compressed files using touch

Open scorreard opened this issue 8 months ago • 3 comments

PR checklist

Closes #5409

Used the following command line to update all the main.nf : sed -i -r -e '/touch.*.gz/s/touch/echo "" | gzip >/' modules/nf-core/*/main.nf

scorreard avatar Mar 24 '25 15:03 scorreard

One of the tool doesn't have tests (getorganelle_fromreads), I openned an issue https://github.com/nf-core/modules/issues/8007 Solving this should solve 2 of the failing checks

scorreard avatar Mar 25 '25 08:03 scorreard

pytests issues should be fixed when we migrate

maxulysse avatar Mar 25 '25 08:03 maxulysse

Creating issues associated to the failing tests :

  • Getorganelle/fromreads failed chack: https://github.com/nf-core/modules/issues/8007
  • strelka/somatic failed check : https://github.com/nf-core/modules/issues/8031
  • phakorra failed check : https://github.com/nf-core/modules/issues/8032
  • gatk4/mutect2 failed check : https://github.com/nf-core/modules/issues/8033

scorreard avatar Mar 25 '25 11:03 scorreard

Removed getorganelle/fromreads

famosab avatar Aug 11 '25 10:08 famosab

Remove change to gatk4/mergevcfs because that is used in a strelka related subworkflow #7969

famosab avatar Aug 11 '25 11:08 famosab

Good catch up on this PR @famosab

maxulysse avatar Aug 11 '25 12:08 maxulysse