fix(theme): make skeleton invisible after data loaded

[chirokas]

• Closes #3214
• Closes #3670

📝 Description

⛳️ Current behavior (updates)

Please describe the current behavior that you are modifying

🚀 New behavior

Please describe the behavior or changes this PR adds

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

Summary by CodeRabbit

• Bug Fixes

  • Resolved issue where the skeleton loader remained visible after data was loaded.
  • Fixed overflow issue with the skeleton component to enhance UI rendering.

• New Features

  • Introduced new visibility properties and transition effects for the skeleton component to improve loading animations.

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: 8228e3e96830a457f756a3be9192ad82201ef77b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@nextui-org/theme	Patch
@nextui-org/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nextui-storybook-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 23, 2024 8:58am

[vercel[bot]]

@chirokas is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai[bot]]

Walkthrough

The update to the @nextui-org/theme package enhances the skeleton component by making it invisible after data is loaded. This involves adjusting visibility, opacity, and transition properties, while also adding a new CSS class. These improvements prevent skeletons from overlapping with other elements and fix a skeleton overflow issue, addressing issues #3214 and #3670.

Changes

File Path	Change Summary
.changeset/twelve-ants-leave.md	Introduced a patch making the skeleton invisible after data is loaded and fixed overflow issues.
packages/core/theme/src/components/skeleton.ts	Adjusted visibility and opacity settings, modified transition properties, and added a new CSS class for pseudo-elements.
packages/core/theme/src/utilities/transition.ts	Corrected transition-property declarations and added .transition-opacity-visibility CSS class.

Assessment against linked issues

Objective (Issue #)	Addressed	Explanation
Skeleton animation should not overlay elements ( #3214)	✅
isLoaded prop should hide the skeleton ( #3214)	✅
Fix skeleton overflow issue (#3670)	✅

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[jrgarciadev]

@wingkwong I belive this can be fixed by using z-[-1] when loaded what do you think?

[daveycodez]

Any way to use this fix in my project? Whenever isLoaded gets set to true, it renders weird bars behind the Skeleton. Only happens when children are inside the skeleton. On Chrome

[wingkwong]

@chirokas can you also take a look at the animation flashing issue mentioned in #3670?

[u3u]

@wingkwong @jrgarciadev This modification has caused the regression of issues #1502 and #2677. https://github.com/nextui-org/nextui/blob/canary/packages/core/theme/src/utilities/transition.ts https://github.com/nextui-org/nextui/commits/canary/packages/core/theme/src/utilities/transition.ts

[u3u]

https://tailwindcss.com/docs/transition-duration#using-custom-values Sorry, I made a mistake! After upgrading TailwindCSS, you need to set transitionDuration separately.

[wingkwong]

This modification has caused the regression of issues #1502 and #2677.

https://github.com/nextui-org/nextui/blob/canary/packages/core/theme/src/utilities/transition.ts

https://github.com/nextui-org/nextui/commits/canary/packages/core/theme/src/utilities/transition.ts

Will check when I get access to my laptop later

[wingkwong]

No worries. Thanks for the update.