nextui icon indicating copy to clipboard operation
nextui copied to clipboard

Autocomplete component (Multiple Selection)

Open amauryfischer opened this issue 2 years ago β€’ 6 comments

πŸ“ Description

Add support for multiple selection via selectionMode "single" or "multiple" to the autocomplete component.

⛳️ Current behavior (updates)

The current behavior only allows single selection. This is because react-stately uses useComboStateProps, which only allows for single selection. The "multi" version in react-stately doesn't seem to be a complete project: https://github.com/adobe/react-spectrum/issues/2140. What I propose is to create a new hook called "useMultiComboBoxState" and tweak the original behavior to allow for both multiple and single selection.

πŸš€ New behavior

Allow the user to select multiple elements using selectionMode.

πŸ’£ Is this a breaking change (Yes/No):

No

πŸ“ Additional Information

This is a work in progress. Since this is my first PR, please don't hesitate to guide me through the coding and/or style.

amauryfischer avatar Nov 03 '23 13:11 amauryfischer

⚠️ No Changeset found

Latest commit: 333ec0e5067d9bac03724b242a26d070fbc67238

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Nov 03 '23 13:11 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
nextui-storybook-v2 βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 3, 2023 4:15pm

vercel[bot] avatar Nov 03 '23 13:11 vercel[bot]

@amauryfischer is attempting to deploy a commit to the NextUI Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Nov 03 '23 13:11 vercel[bot]

@jrgarciadev Sorry i'm not sure how i'm supposed to commit on the new branch you created, so i just forked again and created a new PR on you're newly created branch....

amauryfischer avatar Nov 03 '23 13:11 amauryfischer

可δ»₯ζ”―ζŒε€šι€‰δΊ†δΈ

luckLs avatar Dec 25 '23 05:12 luckLs

Is this planning on being merged?

hackr-sh avatar Jan 30 '24 19:01 hackr-sh

! would love to see this get merged

Elfari1028 avatar Mar 11 '24 10:03 Elfari1028

Closing due to inactivity.

wingkwong avatar Apr 21 '24 07:04 wingkwong

Not that many changes there, any hope for adding this soon?

impact-ls avatar Jul 26 '24 17:07 impact-ls