nextclade
nextclade copied to clipboard
ENH: warn if compression ending detected but request compression type not supported
I tried to find out whether lz4 is supported, so I ran the following command:
~/Downloads/tmp via 🅒 nextstrain
❯ nextclade run -D data -t test.tsv data/sequences.fasta -o aligned.fasta.lz4
It completed successfully but it turns out the output is not compressed. It may be good to indicate if there's no compression with a warning or info. Right now this seems to be logged in debug only?
The supported formats are listed in the help.
How do I check for unsupported formats? They are unsupported for a reason - the set of unsupported formats is unknown. How do you imagine the logic would look like?
There is no easy solution, you're right. One could have a list of unsupported compressions, like lz4, zip, etc or treat things after .fasta that isn't supported as unsupported.
This is not really important though. It just felt a bit blackboxy to not know for sure whether compression works or not.
It just felt a bit blackboxy to not know for sure whether compression works or not.
Most users will learn about compression from the help text, because it's the only place it is mentioned. And formats are listed there. So hopefully this should not be too blackboxy for outside people.