ncov icon indicating copy to clipboard operation
ncov copied to clipboard

Introduce minimum augur version check

Open jameshadfield opened this issue 2 years ago • 2 comments

I implemented this as part of updating #1000, but there are so many ways this pipeline may be run (and which I don't have experience with) that it's not appropriate for that PR. The downside of false-positives outweighs the benefits, so any version check has to be sure we are using the augur version we think we are - probably more so than in the code's current form. It would be worth it to catch these incompatibilities early as I'm sure this'll trip up some people.

Note that this PR failed CI in a useful way :)

Your version of augur (21.1.0) needs to be upgraded to use this workflow.
The minimum augur version required is 22.0.0.

jameshadfield avatar May 16 '23 05:05 jameshadfield

There is an ancient (2-year-old now) PR that does something similar but only when the workflow errors. Checking preemptively seems maybe better, though.

huddlej avatar May 16 '23 21:05 huddlej

Noting that this is analagous to https://github.com/nextstrain/mpox/commit/d9f6d474391c1e657a5deec1bfd0ebb90b1ac4d2.

victorlin avatar Nov 30 '23 20:11 victorlin