talk-android icon indicating copy to clipboard operation
talk-android copied to clipboard

Not usable offline and slow on bad connection

Open jancborchardt opened this issue 7 years ago • 21 comments

The list of calls and contacts seems to load from the server every time the app is opened. This results in a second at least of unresponsiveness and more on usual mobile connections.

When offline (or in a tunnel or plane) you are not able to view any conversations or messages.

We should cache the

  • conversations,
  • contacts and
  • messages

so loading is instant. Updates from the server can still be fed in when they come.

@mario, and same for iOS app @ivansss

jancborchardt avatar Jun 27 '18 16:06 jancborchardt

🎉

szaimen avatar Apr 05 '20 21:04 szaimen

Why this is closed? This is not working. v11.1.2 don't show anything (blank list of conversations) when phone in airplane mode.

kai11 avatar Jul 02 '21 14:07 kai11

Yes, this was only fixed in a different branch. -> reopening

szaimen avatar Jul 02 '21 14:07 szaimen

cc @mahibi @AndyScherzinger

szaimen avatar Jul 02 '21 14:07 szaimen

thanks for reopening @szaimen ! Indeed that's a very important issue that needs to be solved!

mahibi avatar Jul 02 '21 14:07 mahibi

Is this something that is going to be implemented as its been quiet in here since 2018 with no real update as far as I can see?

MRFU510N88 avatar Jul 08 '21 07:07 MRFU510N88

We plan to have this yes, while we don't have a fixed date/release so no ETA. The age of an issue has no implication about a feature being implemented at some point or not.

AndyScherzinger avatar Jul 08 '21 08:07 AndyScherzinger

I appreciate that,

The purpose of my previous comment was to shed some light on whether there were any plans to implement this as there was no definitive responses to support any development having taken place.

I'm sure most will agree this request is a primary feature of any messaging platform and NC Talk would benefit from the ability.

Thank you for your consideration.

MRFU510N88 avatar Jul 08 '21 08:07 MRFU510N88

The purpose of my previous comment was to shed some light on whether there were any plans to implement this as there was no definitive responses to support any development having taken place.

Thanks for the hint, I labelled it accordingly now 👍

I'm sure most will agree this request is a primary feature of any messaging platform and NC Talk would benefit from the ability.

Absolutely while it is hard to say when it is getting implemented since there are usually other features one might also consider primary features :)

AndyScherzinger avatar Jul 08 '21 12:07 AndyScherzinger

I've read in Nextcloud Talk V9.0 change log that it has offline support.

But I see something like this when I open the Android app without internet connection. Is this something related to discussed issue?

image

mokazemi avatar May 09 '22 18:05 mokazemi

Hi, every one i have a plan to make the content visible even on offline. But i can't able to edit that file. it show that it was read only file. I'm using android studio it not allowing me to edit such file. some buddy help me to make it as writeable file.

At classes.jar/coil/network/NetworkObservance.kt we can able to make the application to viewable on offline but confusing the condition statement. so help me friends.

dinesh-dot-com avatar Aug 25 '22 10:08 dinesh-dot-com

Hi @DineshRefex thanks for taking an interest in this matter, this is highly appreciated. To comment on your approach, I believe it is not the right way to change a 3rd party library in use (in this case coil) but rather to find a way to cache the files to disc in case they had been loaded before.

Cc @mahibi @timkrueger in case you are aware of any caching on place already when loading files through coil (or any other approach in place)

AndyScherzinger avatar Aug 25 '22 11:08 AndyScherzinger

Thanks for the reply bro @AndyScherzinger , what is the possibility for offline mode.

dinesh-dot-com avatar Aug 25 '22 12:08 dinesh-dot-com

Would need to look into what coil can do, or you might be able to look into coil and if it offers some caching capabilities. I am currently afk for the week.

AndyScherzinger avatar Aug 25 '22 19:08 AndyScherzinger

Hello @DineshRefex .Thank you very much for your interest to implement offline support.

Offline support is a major architectural and behavioral change to the app. There's so many things that can go wrong design-wise and functionality-wise. For that an experienced Android developer with a good understanding of Talk is needed. Unfortunately, this is not suited for first time contributors, and is something we want to tackle ourselves.

If you're interested beside this issue to contribute to NC Talk for Android, your help is very welcome. And we're happy to help starting. Good issues to start a labeled with good first issue.

timkrueger avatar Aug 30 '22 15:08 timkrueger

Thanks, I will check it out

On Tue, 30 Aug, 2022, 8:56 pm Tim Krüger, @.***> wrote:

Hello @DineshRefex https://github.com/DineshRefex .Thank you very much for your interest to implement offline support.

Offline support is a major architectural and behavioral change to the app. There's so many things that can go wrong design-wise and functionality-wise. For that an experienced Android developer with a good understanding of Talk is needed. Unfortunately, this is not suited for first time contributors, and is something we want to tackle ourselves.

If you're interested beside this issue to contribute to NC Talk for Android, your help is very welcome. And we're happy to help starting. Good issues to start a labeled with good first issue https://github.com/nextcloud/talk-android/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 .

— Reply to this email directly, view it on GitHub https://github.com/nextcloud/talk-android/issues/217#issuecomment-1231823241, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZH7Y7QHEKWQE7IBO7BTLTDV3YR2XANCNFSM4FHIFEDQ . You are receiving this because you were mentioned.Message ID: @.***>

-- *The information contained in this communication is intended solely for the use of the individual or entity to whom it is addressed and others authorized to receive it. **Please note that as the recipient, it is your responsibility to check the email for malicious content or software. *It may contain confidential or legally privileged information. If you are not the intended recipient you are hereby notified that any disclosure, copying, distribution or taking any action in reliance on the contents of this information is strictly prohibited and may be unlawful. If you have received this communication in error, please notify us immediately by responding to this email.The firm is neither liable for the proper and complete transmission of the information contained in this communication nor for any delay in its receipt.

dinesh-dot-com avatar Aug 31 '22 08:08 dinesh-dot-com

I'm really interested to enable offline mode on nextcloud talk. But I can't able to edit some files because there are read only file.

I'm stucked

On Tue, 30 Aug, 2022, 8:56 pm Tim Krüger, @.***> wrote:

Hello @DineshRefex https://github.com/DineshRefex .Thank you very much for your interest to implement offline support.

Offline support is a major architectural and behavioral change to the app. There's so many things that can go wrong design-wise and functionality-wise. For that an experienced Android developer with a good understanding of Talk is needed. Unfortunately, this is not suited for first time contributors, and is something we want to tackle ourselves.

If you're interested beside this issue to contribute to NC Talk for Android, your help is very welcome. And we're happy to help starting. Good issues to start a labeled with good first issue https://github.com/nextcloud/talk-android/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 .

— Reply to this email directly, view it on GitHub https://github.com/nextcloud/talk-android/issues/217#issuecomment-1231823241, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZH7Y7QHEKWQE7IBO7BTLTDV3YR2XANCNFSM4FHIFEDQ . You are receiving this because you were mentioned.Message ID: @.***>

-- *The information contained in this communication is intended solely for the use of the individual or entity to whom it is addressed and others authorized to receive it. **Please note that as the recipient, it is your responsibility to check the email for malicious content or software. *It may contain confidential or legally privileged information. If you are not the intended recipient you are hereby notified that any disclosure, copying, distribution or taking any action in reliance on the contents of this information is strictly prohibited and may be unlawful. If you have received this communication in error, please notify us immediately by responding to this email.The firm is neither liable for the proper and complete transmission of the information contained in this communication nor for any delay in its receipt.

dinesh-dot-com avatar Aug 31 '22 08:08 dinesh-dot-com

Thank you for your help @tim kruger.

On Tue, 30 Aug, 2022, 8:56 pm Tim Krüger, @.***> wrote:

Hello @DineshRefex https://github.com/DineshRefex .Thank you very much for your interest to implement offline support.

Offline support is a major architectural and behavioral change to the app. There's so many things that can go wrong design-wise and functionality-wise. For that an experienced Android developer with a good understanding of Talk is needed. Unfortunately, this is not suited for first time contributors, and is something we want to tackle ourselves.

If you're interested beside this issue to contribute to NC Talk for Android, your help is very welcome. And we're happy to help starting. Good issues to start a labeled with good first issue https://github.com/nextcloud/talk-android/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 .

— Reply to this email directly, view it on GitHub https://github.com/nextcloud/talk-android/issues/217#issuecomment-1231823241, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZH7Y7QHEKWQE7IBO7BTLTDV3YR2XANCNFSM4FHIFEDQ . You are receiving this because you were mentioned.Message ID: @.***>

-- *The information contained in this communication is intended solely for the use of the individual or entity to whom it is addressed and others authorized to receive it. **Please note that as the recipient, it is your responsibility to check the email for malicious content or software. *It may contain confidential or legally privileged information. If you are not the intended recipient you are hereby notified that any disclosure, copying, distribution or taking any action in reliance on the contents of this information is strictly prohibited and may be unlawful. If you have received this communication in error, please notify us immediately by responding to this email.The firm is neither liable for the proper and complete transmission of the information contained in this communication nor for any delay in its receipt.

dinesh-dot-com avatar Sep 01 '22 03:09 dinesh-dot-com

I would like to say that this is the only important missing feature that prevents my collaborators from adopting the application.

Waiting 2-3 seconds when loading the application to see the list of conversations + 2-3 seconds when opening the conversation to see a message, it's definitely too slow...

Other than that, everything else is great!

louim-lbs avatar Sep 18 '23 10:09 louim-lbs

Dear all,

when staff members install Nextcloud Talk on private devices, chats and files belonging to the organisation become difficult to control and to keep secure. So having no caching is in that moment a security advantage. Please consider this when implementing caching. At best, the nextcloud server could impose a policy on caching that mobile clients respect.

rriemann avatar Oct 25 '23 15:10 rriemann

This security "feature" is indeed interesting, I didn't think about it.

This could be an option configurable by the admin, maybe for each user and/or each conversation.

louim-lbs avatar Oct 25 '23 15:10 louim-lbs