server icon indicating copy to clipboard operation
server copied to clipboard

[BITV] 9.1.4.3/3.4 - "Details" section / "Share" menu - Both the label and note do not meet the contrast requirements for text. (2)

Open AndyScherzinger opened this issue 2 years ago • 4 comments

  • [ ] Fix in https://github.com/nextcloud/nextcloud-vue/tree/enh/a11y-texteditable-contrast

9a74478ddfe340c9129213eff5b58e70

Details

https://report.bitvtest.de/default-en/d63601ac-cb34-4645-8256-66bec78964a0.html#checkpoint-6fe46b78da-v3-n4

  • [ ] 9.1.4.3/10.4 - https://report.bitvtest.de/default-en/d63601ac-cb34-4645-8256-66bec78964a0.html#checkpoint-6fe46b78da-v10-n4

AndyScherzinger avatar Mar 01 '23 18:03 AndyScherzinger

On master

  • [x] Share label
  • [ ] Share note

Pytal avatar Apr 29 '23 01:04 Pytal

NcAction* components are using opacity to indicate focus/hover

The share note is using NcActionTextEditable

To ensure we are using contrast-verified colors we should stop using opacity in NcAction* components and go with one of 2 options below

  1. Replace $opacity_normal: .7--color-text-maxcontrast and $opacity_full: 1--color-main-text image
  2. Set the base color to --color-main-text and like the tertiary NcButton: image only use the background color, --color-background-hover, alongside input-specific colors, e.g. --color-primary-element for text field borders, to indicate focus/hover image

Option 2 seems better to me as all options have high readability regardless of focus/hover

NcActionTextEditable examples

Option 1 Option 2
image image

This change will affect all NcAction* components, not just NcActionTextEditable, to maintain consistency

Which option should we go for @jancborchardt?

Pytal avatar May 04 '23 01:05 Pytal

👆 Any option you'd lean towards @nimishavijay?

Pytal avatar May 04 '23 16:05 Pytal

Agreed, option 2 sounds like it has better readability overall :) Here's how it would look like in Mail and Files.

nimishavijay avatar May 04 '23 17:05 nimishavijay