richdocuments icon indicating copy to clipboard operation
richdocuments copied to clipboard

Collabora updates are undetected

Open AssassinTee opened this issue 1 year ago • 4 comments

Describe the bug

When updating the collabora server (maybe automatically by unattended-upgrades) the app doesn't notice a version change. I got a lot of logs with version-mismatch errors. This was solved simply by pressing "save" again at the configuration page for the server, which then updated the version nexctloud thought it has.

To Reproduce Steps to reproduce the behavior:

  1. have a collabora server
  2. have a nextcloud
  3. update collabora server
  4. See version update not beeing detected

Expected behavior Since you show the version and a successful connection in the app, I expected version updates to be automatically detected. This is either a bug-report or a feature-request.

Server details

Operating system: Ubuntu24.04

Web server: yes

Database: yes

PHP version: 8.2

Nextcloud version: 29.0.3

Version of the richdocuments app 8.4.8

Version of Collabora Online before: 24.04.8.(something), now 24.04.9.3-1

Configuration of the richdocuments app No need

AssassinTee avatar Nov 25 '24 07:11 AssassinTee

Can you share which kind of logs you got with the version mismatch? Nextcloud should refetch the capabilities/discovery endpoints of collabora regularly, so they might be outdated for some time i would not expect that to cause issues.

Maybe we can consider doing the background update more often. We have it moved to a dedicated background job with Nextcloud 30 but that only runs one an hour which might be not frequent enough https://github.com/nextcloud/richdocuments/blob/a9c36fd88f2b6d8b5a0fe32ef1e14dbf8f25cc39/lib/Backgroundjobs/ObtainCapabilities.php#L26

juliusknorr avatar Dec 03 '24 13:12 juliusknorr

As I wrote above, we are currently at nextcloud 29.0.3, but I am glad to hear that his is already done for nextcloud 30!

syslog.1:2024-11-26T15:27:38.557163+00:00 collabora coolwsd[813969]: wsd-813969-813982 2024-11-26 15:27:38.557108 +0000 [ websrv_poll ] WRN  Client - server version mismatch, disabling browser cache. Expected: 095d6da30f; Actual URI path with version hash: /browser/dist/l10n/ui-de.json| wsd/FileServer.cpp:564
syslog.1:2024-11-26T15:27:59.282802+00:00 collabora coolwsd[838437]: wsd-838437-838451 2024-11-26 15:27:59.282472 +0000 [ websrv_poll ] WRN  Client - server version mismatch, disabling browser cache. Expected: 095d6da30f; Actual URI path with version hash: /browser/dist/l10n/ui-de.json| wsd/FileServer.cpp:564
syslog.1:2024-11-26T15:31:25.638724+00:00 collabora coolwsd[838437]: wsd-838437-838451 2024-11-26 15:31:25.638650 +0000 [ websrv_poll ] WRN  Client - server version mismatch, disabling browser cache. Expected: 095d6da30f; Actual URI path with version hash: /browser/dist/l10n/ui-de.json| wsd/FileServer.cpp:564
syslog.1:2024-11-26T15:31:50.164105+00:00 collabora coolwsd[839112]: wsd-839112-839124 2024-11-26 15:31:50.164055 +0000 [ websrv_poll ] WRN  Client - server version mismatch, disabling browser cache. Expected: 095d6da30f; Actual URI path with version hash: /browser/dist/l10n/ui-de.json| wsd/FileServer.cpp:564

Here with surrounding errors:

--
syslog.1:2024-11-26T14:50:21.758829+00:00 collabora coolwsd[813969]: wsd-813969-813982 2024-11-26 14:50:21.758731 +0000 [ websrv_poll ] WRN  Client - server version mismatch, disabling browser cache. Expected: 095d6da30f; Actual URI path with version hash: /browser/dist/l10n/ui-de.json| wsd/FileServer.cpp:564
syslog.1-2024-11-26T14:50:21.812872+00:00 collabora coolwsd[813969]: wsd-813969-813982 2024-11-26 14:50:21.812708 +0000 [ websrv_poll ] ERR  FileServerRequestHandler: File not found: Invalid URI request (hash): [/browser/095d6da30f/branding.js].| wsd/FileServer.cpp:787
syslog.1-2024-11-26T14:50:55.498439+00:00 collabora coolwsd[813969]: wsd-813969-813982 2024-11-26 14:50:55.498017 +0000 [ websrv_poll ] ERR  FileServerRequestHandler: File not found: Invalid URI request (hash): [/browser/095d6da30f/branding.js].| wsd/FileServer.cpp:787
syslog.1:2024-11-26T14:50:55.593153+00:00 collabora coolwsd[813969]: wsd-813969-813982 2024-11-26 14:50:55.593050 +0000 [ websrv_poll ] WRN  Client - server version mismatch, disabling browser cache. Expected: 095d6da30f; Actual URI path with version hash: /browser/dist/l10n/ui-de.json| wsd/FileServer.cpp:564
syslog.1-2024-11-26T14:50:55.610276+00:00 collabora coolwsd[813969]: wsd-813969-813982 2024-11-26 14:50:55.610126 +0000 [ websrv_poll ] ERR  FileServerRequestHandler: File not found: Invalid URI request (hash): [/browser/095d6da30f/branding.js].| wsd/FileServer.cpp:787
syslog.1-2024-11-26T14:54:04.403815+00:00 collabora PackageKit: daemon quit
syslog.1-2024-11-26T14:54:04.412394+00:00 collabora systemd[1]: packagekit.service: Deactivated successfully.
--
syslog.1:2024-11-26T14:56:47.443155+00:00 collabora coolwsd[813969]: wsd-813969-813982 2024-11-26 14:56:47.442994 +0000 [ websrv_poll ] WRN  Client - server version mismatch, disabling browser cache. Expected: 095d6da30f; Actual URI path with version hash: /browser/dist/l10n/ui-de.json| wsd/FileServer.cpp:564
syslog.1-2024-11-26T14:56:47.465910+00:00 collabora coolwsd[813969]: wsd-813969-813982 2024-11-26 14:56:47.465796 +0000 [ websrv_poll ] ERR  FileServerRequestHandler: File not found: Invalid URI request (hash): [/browser/095d6da30f/branding.js].| wsd/FileServer.cpp:787
syslog.1-2024-11-26T14:57:32.575122+00:00 collabora coolwsd[813969]: wsd-813969-813982 2024-11-26 14:57:32.574776 +0000 [ websrv_poll ] ERR  FileServerRequestHandler: File not found: Invalid URI request (hash): [/browser/095d6da30f/branding.css].| wsd/FileServer.cpp:787
syslog.1-2024-11-26T14:57:32.575450+00:00 collabora coolwsd[813969]: wsd-813969-813982 2024-11-26 14:57:32.574994 +0000 [ websrv_poll ] ERR  FileServerRequestHandler: File not found: Invalid URI request (hash): [/browser/095d6da30f/branding.js].| wsd/FileServer.cpp:787
--
syslog.1:2024-11-26T15:27:38.557163+00:00 collabora coolwsd[813969]: wsd-813969-813982 2024-11-26 15:27:38.557108 +0000 [ websrv_poll ] WRN  Client - server version mismatch, disabling browser cache. Expected: 095d6da30f; Actual URI path with version hash: /browser/dist/l10n/ui-de.json| wsd/FileServer.cpp:564
syslog.1-2024-11-26T15:27:38.575618+00:00 collabora coolwsd[813969]: wsd-813969-813982 2024-11-26 15:27:38.575584 +0000 [ websrv_poll ] ERR  FileServerRequestHandler: File not found: Invalid URI request (hash): [/browser/095d6da30f/branding.js].| wsd/FileServer.cpp:787
syslog.1-2024-11-26T15:27:43.416009+00:00 collabora systemd[1]: fwupd.service: Deactivated successfully.
syslog.1-2024-11-26T15:27:49.941988+00:00 collabora coolwsd[834889]: kit-834889-834889 2024-11-26 15:27:49.941650 +0000 [ kitbroker_040 ] WRN  #19: Background save process disconnected but not terminated 838420| kit/KitWebSocket.cpp:338
--
syslog.1:2024-11-26T15:27:59.282802+00:00 collabora coolwsd[838437]: wsd-838437-838451 2024-11-26 15:27:59.282472 +0000 [ websrv_poll ] WRN  Client - server version mismatch, disabling browser cache. Expected: 095d6da30f; Actual URI path with version hash: /browser/dist/l10n/ui-de.json| wsd/FileServer.cpp:564
syslog.1-2024-11-26T15:27:59.304073+00:00 collabora coolwsd[838437]: wsd-838437-838451 2024-11-26 15:27:59.304006 +0000 [ websrv_poll ] ERR  FileServerRequestHandler: File not found: Invalid URI request (hash): [/browser/095d6da30f/branding.js].| wsd/FileServer.cpp:787
syslog.1-2024-11-26T15:28:04.074543+00:00 collabora coolwsd[838448]: kit-838448-838448 2024-11-26 15:27:58.285146 +0000 [ kit_spare_001 ] INF  New kit client websocket inserted.| kit/Kit.cpp:3679
syslog.1-2024-11-26T15:28:04.074625+00:00 collabora coolwsd[838448]: kit-838448-838448 2024-11-26 15:27:58.285148 +0000 [ kit_spare_001 ] INF  Kit initialization complete: setting log-level to [warning] as configured.| kit/Kit.cpp:3684

AssassinTee avatar Dec 04 '24 09:12 AssassinTee

I was able to reproduce this with nextcloud 29.0.3 and coolwsd version 24.04.9.3 upgraded to 24.04.9.4

mwinkens avatar Dec 05 '24 16:12 mwinkens

@pedropintosilva Do you have any idea why the hash would be outdated here? I imagine the URL for browser.html is not up to date, but why would that cause old urls to be called for any other JS/CSS files?

juliusknorr avatar Dec 05 '24 21:12 juliusknorr