forms
forms copied to clipboard
Optimization method FormsService::canSubmit
Currently, to check if a user has filled out the form, all entities are retrieved, and then two loops are performed at the PHP. My version does the same thing but with a single simple query.
Codecov Report
Attention: Patch coverage is 52.63158% with 9 lines in your changes missing coverage. Please review.
Project coverage is 46.03%. Comparing base (
f6c1b8a) to head (a0b26df). Report is 394 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #2225 +/- ##
============================================
+ Coverage 45.95% 46.03% +0.08%
- Complexity 797 800 +3
============================================
Files 65 66 +1
Lines 3066 3065 -1
============================================
+ Hits 1409 1411 +2
+ Misses 1657 1654 -3
@AIlkiv could you please rebase on current main?
Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.
We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.
Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6
Thank you for contributing to Nextcloud and we hope to hear from you soon!
(If you believe you should not receive this message, you can add yourself to the blocklist.)