forms icon indicating copy to clipboard operation
forms copied to clipboard

Add support of multi-columns descriptions

Open Koc opened this issue 1 year ago • 6 comments

Now we can use multi-columns descriptions thankful to markdown-it-container plugin

::::: columns
:::: column-double
first column has double relative width (ie 2/3 of total width) 
::::
:::: column-single
second column has single relative width (ie 1/3 of total width)
::::
:::::
:mag: Preview

image image

Koc avatar Jun 09 '24 19:06 Koc

I am not sure about this, I do not see a good use case and will make thing more complex. I would probably stick with CommonMark to keep it simple.

Opinions @jancborchardt @Chartman123 ?

susnux avatar Jun 12 '24 21:06 susnux

Yeah same for me... another dependency for only a really small benefit.

Chartman123 avatar Jun 12 '24 21:06 Chartman123

for our use case It has sense for students quizzes, e.g. we have some image/schema on the left column and a question on the right column

Koc avatar Jun 12 '24 23:06 Koc

Updates:

  • properly handle columns on mobile
  • added more real-life example in PR description
  • fixed pipeline

Koc avatar Jun 16 '24 21:06 Koc

@Koc thanks for the updated description with the preview... How would this work together with your other PR to implement Text as a Markdown editor? As far as I could see Text doesn't support multi-columns.

Chartman123 avatar Jun 17 '24 09:06 Chartman123

@Chartman123 I've plan to close #2164 because it requires much more work than I expected for adding images support. So there are no any conflicts with this 2 PRs anymore :smiley:

Koc avatar Jun 17 '24 13:06 Koc

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

github-actions[bot] avatar Dec 19 '24 02:12 github-actions[bot]

@Koc you can follow the blocklist link in the last post to add your username to the list so that your PRs don't get this feedback post :)

Chartman123 avatar Dec 19 '24 10:12 Chartman123