forms icon indicating copy to clipboard operation
forms copied to clipboard

Data source for the Analytics App

Open Rello opened this issue 1 year ago • 10 comments

This pull adds a data source to report on forms with Analyitcs

  • [x] real time reporting
  • [x] scheduled data loads (for trends)
  • [x] charts and/or tables
  • [x] multi page dashboards (coming with Analytics 5)
  • [x] PDF/print dashboards (coming with Analytics 5)
  • [ ] one-click dashboard creation for all questions of a form

Data source selection

Bildschirmfoto 2024-06-01 um 17 43 25


Single report

Bildschirmfoto 2024-06-01 um 17 46 31


Dashboard

Bildschirmfoto 2024-06-01 um 17 48 57

Rello avatar Jun 01 '24 15:06 Rello

Codecov Report

Attention: Patch coverage is 0% with 53 lines in your changes missing coverage. Please review.

Project coverage is 45.17%. Comparing base (e019081) to head (0530cd1). Report is 14 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2195      +/-   ##
============================================
- Coverage     45.95%   45.17%   -0.79%     
- Complexity      797      811      +14     
============================================
  Files            65       67       +2     
  Lines          3066     3119      +53     
============================================
  Hits           1409     1409              
- Misses         1657     1710      +53     

codecov[bot] avatar Jun 01 '24 15:06 codecov[bot]

CI is failing a lot (PHP code style, missing stubs for psalm, missing unit tests), please fix this :)

Also cc @Chartman123, what do you think about this?

susnux avatar Jun 01 '24 21:06 susnux

@susnux if this doesn't come with any problems when the Analytics app isn't installed, I'd be fine with it.

Chartman123 avatar Jun 04 '24 08:06 Chartman123

@Chartman123 I just did another test on my side - all clean. no nextcloud.log happy for an other retest

...we only need to find a way for the psalm and the unit-tests...

Rello avatar Jun 04 '24 13:06 Rello

@Rello are you ready with this PR? Perhaps you could add some more unit tests, so that the Codecov workflows turn green, too 🙂

Before we merge this, also please do a rebase on current main and squash all the commits into one single commit.

Chartman123 avatar Jun 24 '24 12:06 Chartman123

Hi @Chartman123 I will retest one more time and post an update here. regarding unit tests, I would need assistant. I never did these in the past as the dev-capacity is pretty limited...

Rello avatar Jun 24 '24 12:06 Rello

@Rello please don't merge the main branch into your branch and use git rebase instead :)

Chartman123 avatar Jun 25 '24 08:06 Chartman123

@Rello please don't merge the main branch into your branch and use git rebase instead :)

Hi, any hint on the background? I was always doing this until now. but open to learn something better. Tx!

Rello avatar Jun 25 '24 09:06 Rello

Rebasing results in a cleaner commit history, when we merge the changes back into our main :)

Chartman123 avatar Jun 25 '24 09:06 Chartman123

@Chartman123 @susnux all tests are green - besides the codecov part and I have no idea how to solve this. what do you suggest to do here?

Rello avatar Jul 03 '24 19:07 Rello

🙏🏻

Rello avatar Jul 29 '24 07:07 Rello

@susnux we should have squashed the commits into one single commit first... ;)

Chartman123 avatar Jul 29 '24 07:07 Chartman123