forms icon indicating copy to clipboard operation
forms copied to clipboard

Add QR-Code for Share Links

Open Himmelxd opened this issue 1 year ago • 4 comments

Closes #1606 at least supposed to image

Himmelxd avatar May 11 '24 19:05 Himmelxd

@Himmelxd thanks for this PR :) I added some comments on the code

Chartman123 avatar May 12 '24 08:05 Chartman123

Thank you for your review and great comments :D

Himmelxd avatar May 13 '24 15:05 Himmelxd

PS: My code suggestions are only to show what I meant, they are not tested and need some refactoring ;)

susnux avatar May 21 '24 09:05 susnux

@Himmelxd to fix the remaining Lint/Prettier errors, you should run npx prettier . --write in your Forms directory. This will reformat all files according to the prettier rules. Instead of the . you can also specify the failing files and only reformat them.

Depending on your editor, there are also some extensions that allow formatting single files directly.

Chartman123 avatar Jun 24 '24 17:06 Chartman123

@Himmelxd Thank you very much, awesome work :rocket: Hope to see more contributions in the future!

susnux avatar Jul 07 '24 17:07 susnux

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

github-actions[bot] avatar Dec 19 '24 02:12 github-actions[bot]