forms icon indicating copy to clipboard operation
forms copied to clipboard

Way to Forms 5

Open Chartman123 opened this issue 1 year ago • 5 comments

This is a collection of tasks needed for preparation/release of Forms v5.

4.3 release:

  • [x] #2071
  • [x] #2072
  • [x] #2079
  • [x] #2278
  • [x] #2333

See sub-issues for 5.0 related tasks

Chartman123 avatar Apr 02 '24 21:04 Chartman123

How about unifying our API? Currently there is not really a pattern in the API routes - especially logical nesting.

For example for forms:

What Current New
Get forms GET /forms GET /forms
New form POST /form POST /forms :exclamation:
Get form GET /form/:id: GET /forms/:id:
Clone form POST /form/clone/:id: POST /forms/:id:/clone
Update form PATCH /form/update PATCH /forms/:id:
Transfer ownership POST /form/transfer - (just use the patch)
Delete form DELETE /form/:id: DELETE /forms/:id:

This is just an example, but I think it would make the API more logical

susnux avatar Apr 15 '24 17:04 susnux

Yes I think this would definitely make sense... This was always something illogical to me

Chartman123 avatar Apr 15 '24 20:04 Chartman123

I do not see any use case for the hash other than the legacy link, probably we can also remove that with v5?

susnux avatar Apr 16 '24 09:04 susnux

Should we add the newly organized endpoints already in 4.3 so that users of the API can already adapt to the new structure?

And regarding the hash: If we remove it, our internal links/URLs would only have the id, right? I think we should at least have a look at the APIs so that we don't mix it there (sometimes hash is needed, sometimes the id).

Chartman123 avatar Apr 16 '24 11:04 Chartman123

And regarding the hash: If we remove it, our internal links/URLs would only have the id, right? I think we should at least have a look at the APIs so that we don't mix it there (sometimes hash is needed, sometimes the id).

Yes I would just use the form id, like for files. if you use the internal share link it is just the file id.

susnux avatar Apr 20 '24 20:04 susnux